Issue 10332173: Attempt to reapply crrev.com/137083.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332173: Attempt to reapply crrev.com/137083. (Closed)

Created:
8 years, 7 months ago by robertshield

Modified:
8 years, 7 months ago

Reviewers:
bradn, bradnelson, kerz_chromium, kerz_google, M-A Ruel

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Attempt to reapply crrev.com/137083. Disabling precompiled headers for official builds with msvs2010 Selectively disabling precompiled headers for release builds with msvs2010 Precompiled headers seem to interact badly with auto-sharding using the msvs_shard option. Incudes speculative fix for KeyError in Linux gyp builds (see http://build.chromium.org/p/chromium.pyauto/builders/Linux%20%28deb%29/builds/33094/steps/update/logs/stdio for details) that removes line 140 from http://codereview.chromium.org/10392091/diff/6/build/common.gypi BUG=127875 TEST=builds on trybots. R=kerz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137166

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	build/common.gypi	View	1	5 chunks	+17 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

M-A Ruel

BTW, you can "git try -t compile", then use NOTRY=true or just commit manually. lgtm

8 years, 7 months ago (2012-05-15 14:49:48 UTC) #3

LGTM