Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 10332172: messages.js: Add toString to CallSite (which describes a frame of the stack trace). (Closed)

Created:
8 years, 7 months ago by marja
Modified:
8 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

messages.js: Add toString to CallSite (which describes a frame of the stack trace). This is useful for users who overwrite Error.prepareStackTrace but want to use this functionality for formatting the individual frames. BUG=NONE TEST=NONE Review URL: https://chromiumcodereview.appspot.com/10388140 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@11563 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 Committed: https://code.google.com/p/v8/source/detail?r=11568

Patch Set 1 #

Patch Set 2 : ? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -62 lines) Patch
M src/messages.js View 5 chunks +63 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ptal
8 years, 7 months ago (2012-05-15 11:32:26 UTC) #1
Yang
On 2012/05/15 11:32:26, marja wrote: > ptal LGTM.
8 years, 7 months ago (2012-05-15 11:54:12 UTC) #2
Yang
8 years, 7 months ago (2012-05-15 12:25:41 UTC) #3
On 2012/05/15 11:54:12, Yang wrote:
> On 2012/05/15 11:32:26, marja wrote:
> > ptal
> 
> LGTM.

Landed as r11568.

Powered by Google App Engine
This is Rietveld 408576698