Fixed thread initialization order in login_utils_browsertest.cc.

Fixed thread initialization order in login_utils_browsertest.cc.

BUG=None
TEST=linux_chromeos bots turn green

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137100

[Joao da Silva, 2012-05-15 09:42:41]

This was broken at https://chromiumcodereview.appspot.com/10185008. The
linux_chromeos run there only compiled and didn't run the browser tests.

[Joao da Silva, 2012-05-15 09:43:36]

@rlp, @pkasting: FYI

[Mattias Nissler (ping if slow), 2012-05-15 09:43:52]

LGTM.

rlp: Please run linux_chromeos tryjobs next time if you make a change to
chromeos-specific code.

[rpetterson, 2012-05-15 16:22:15]

On 2012/05/15 09:43:52, Mattias Nissler wrote:
> LGTM.
> 
> rlp: Please run linux_chromeos tryjobs next time if you make a change to
> chromeos-specific code.

Mattias, I did run linux_chromeos as the lines in this CL were added
specifically to fix an issue on chromeos. Please see:
https://chromiumcodereview.appspot.com/10185008/#ps63120 for the green
linux_chromeos try run.

[Joao da Silva, 2012-05-15 16:32:42]

On Tue, May 15, 2012 at 6:22 PM, <rlp@chromium.org> wrote:

> On 2012/05/15 09:43:52, Mattias Nissler wrote:
>
>> LGTM.
>>
>
>  rlp: Please run linux_chromeos tryjobs next time if you make a change to
>> chromeos-specific code.
>>
>
> Mattias, I did run linux_chromeos as the lines in this CL were added
> specifically to fix an issue on chromeos. Please see:
>
https://chromiumcodereview.**appspot.com/10185008/#ps63120<https://chromiumco...
the green
> linux_chromeos try run.
>
>
http://codereview.chromium.**org/10332170/<http://codereview.chromium.org/103...
>

Hi Rachel,

I only looked at the bot run of the last CL, which compiled but didn't run
tests on linux_chromeos.

The catch is that the bot that failed on the waterfall builds in debug
mode, while linux_chromeos builds in release and doesn't trigger the DCHECK.

All fixed now! :-)

[rpetterson, 2012-05-15 16:45:43]

Ah, got it. I'll watch out for that next time. Thanks for fixing!

On Tue, May 15, 2012 at 9:32 AM, Joao da Silva <joaodasilva@chromium.org>wrote:

> On Tue, May 15, 2012 at 6:22 PM, <rlp@chromium.org> wrote:
>
>> On 2012/05/15 09:43:52, Mattias Nissler wrote:
>>
>>> LGTM.
>>>
>>
>>  rlp: Please run linux_chromeos tryjobs next time if you make a change to
>>> chromeos-specific code.
>>>
>>
>> Mattias, I did run linux_chromeos as the lines in this CL were added
>> specifically to fix an issue on chromeos. Please see:
>>
https://chromiumcodereview.**appspot.com/10185008/#ps63120<https://chromiumco...
the green
>> linux_chromeos try run.
>>
>>
http://codereview.chromium.**org/10332170/<http://codereview.chromium.org/103...
>>
>
> Hi Rachel,
>
> I only looked at the bot run of the last CL, which compiled but didn't run
> tests on linux_chromeos.
>
> The catch is that the bot that failed on the waterfall builds in debug
> mode, while linux_chromeos builds in release and doesn't trigger the DCHECK.
>
> All fixed now! :-)
>