Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 10332169: Enable Shadow DOM and scoped stylesheet for extensions and Web UI. (Closed)

Created:
8 years, 7 months ago by Hajime Morrita
Modified:
8 years, 6 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Enable Shadow DOM and scoped stylesheet for extensions. BUG=127985 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142323

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implemented new WebPermissionsClient API.wq #

Patch Set 3 : Updated to verify URL using ExtensionDispatcher.wq #

Patch Set 4 : Enable the API only if the experimental permission is given #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/renderer/chrome_render_view_observer.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 3 2 chunks +27 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (0 generated)
Hajime Morrita
Hi Dimitri, This turne the shadow flag on for extensions. Do you have any idea ...
8 years, 7 months ago (2012-05-15 09:31:11 UTC) #1
Aaron Boodman
https://chromiumcodereview.appspot.com/10332169/diff/1/chrome/renderer/extensions/extension_dispatcher.cc File chrome/renderer/extensions/extension_dispatcher.cc (right): https://chromiumcodereview.appspot.com/10332169/diff/1/chrome/renderer/extensions/extension_dispatcher.cc#newcode262 chrome/renderer/extensions/extension_dispatcher.cc:262: // This allows extension developes to try thiese features ...
8 years, 7 months ago (2012-05-15 18:30:55 UTC) #2
Hajime Morrita
Hi Aaron, thanks for your feedback. As you pointed out, original change doesn't work with ...
8 years, 6 months ago (2012-05-30 04:34:46 UTC) #3
Aaron Boodman
It's not correct to just look at the URL, as this is both too inclusive ...
8 years, 6 months ago (2012-05-30 20:31:52 UTC) #4
Hajime Morrita
Hi Aaron, thanks for your advice! That does help. I updated the patch in that ...
8 years, 6 months ago (2012-06-01 05:50:26 UTC) #5
Hajime Morrita
Hi Aaron, could you take another look? I updated the patch to follow recent discussion.
8 years, 6 months ago (2012-06-14 08:42:04 UTC) #6
Aaron Boodman
lgtm
8 years, 6 months ago (2012-06-14 22:14:41 UTC) #7
Hajime Morrita
Thanks!
8 years, 6 months ago (2012-06-14 23:35:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/10332169/10001
8 years, 6 months ago (2012-06-14 23:35:50 UTC) #9
commit-bot: I haz the power
Change committed as 142323
8 years, 6 months ago (2012-06-15 02:16:48 UTC) #10
Mihai Parparita -not on Chrome
https://chromiumcodereview.appspot.com/10332169/diff/10001/chrome/renderer/chrome_render_view_observer.cc File chrome/renderer/chrome_render_view_observer.cc (right): https://chromiumcodereview.appspot.com/10332169/diff/10001/chrome/renderer/chrome_render_view_observer.cc#newcode498 chrome/renderer/chrome_render_view_observer.cc:498: ExtensionURLInfo(origin, document.url())); This doesn't seem to quite work. For ...
8 years, 6 months ago (2012-06-20 19:47:01 UTC) #11
Mihai Parparita -not on Chrome
On Wed, Jun 20, 2012 at 12:47 PM, <mihaip@chromium.org> wrote: > This doesn't seem to ...
8 years, 6 months ago (2012-06-21 01:30:33 UTC) #12
Hajime Morrita
8 years, 6 months ago (2012-06-21 01:34:51 UTC) #13
Good catch, and thanks for taking this.

Powered by Google App Engine
This is Rietveld 408576698