Enable Shadow DOM and scoped stylesheet for extensions and Web UI.

Enable Shadow DOM and scoped stylesheet for extensions.

BUG=127985
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142323

[Hajime Morrita, 2012-05-15 09:31:11]

Hi Dimitri,
This turne the shadow flag on for extensions.
Do you have any idea who is the best reviewer for this?
And if it's you, that would be perfect :-)

[Aaron Boodman, 2012-05-15 18:30:55]

https://chromiumcodereview.appspot.com/10332169/diff/1/chrome/renderer/extens...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10332169/diff/1/chrome/renderer/extens...
chrome/renderer/extensions/extension_dispatcher.cc:262: // This allows extension
developes to try thiese features without
typo: these

https://chromiumcodereview.appspot.com/10332169/diff/1/chrome/renderer/extens...
chrome/renderer/extensions/extension_dispatcher.cc:266:
WebKit::WebRuntimeFeatures::enableShadowDOM(true);
A static flag is not going to be sufficient. A single process can host both
extension and non-extension WebViews.

Take a look at extension_webkit_preferences.cc for an example of how other
WebKit runtime flags are switched on.

[Hajime Morrita, 2012-05-30 04:34:46]

Hi Aaron, thanks for your feedback.
As you pointed out, original change doesn't work with multi-origin pages.
I added WebPermissonClient::allowWebComponents to allow per-frame configuration.
Updated change implemennted it.

Could you take another look?
It uses IsWhitelistedForContentSettings() to decide the availability of web
component API. 

TIA.

[Aaron Boodman, 2012-05-30 20:31:52]

It's not correct to just look at the URL, as this is both too inclusive and too
restrictive.

Given a URL that you want to know whether to enable web components on, you need
to:

1. Get an extension ID from
ExtensionDispatcher::extensions()->GetExtensionOrAppIDByURL(...)
2. Check whether that extension is active in the currentp rocess with
ExtensionDispatcher::IsExtensionActive()

HTH

- a

[Hajime Morrita, 2012-06-01 05:50:26]

Hi Aaron, thanks for your advice! That does help.
I updated the patch in that line. 
I think WebUI is another possible client for Web Components. So I included it to
the whitelist.

Could you take a look once more?

[Hajime Morrita, 2012-06-14 08:42:04]

Hi Aaron, could you take another look?
I updated the patch to follow recent discussion.

[Aaron Boodman, 2012-06-14 22:14:41]

lgtm

[Hajime Morrita, 2012-06-14 23:35:07]

Thanks!

[commit-bot: I haz the power, 2012-06-14 23:35:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/10332169/10001

[commit-bot: I haz the power, 2012-06-15 02:16:48]

Change committed as 142323

[Mihai Parparita -not on Chrome, 2012-06-20 19:47:01]

https://chromiumcodereview.appspot.com/10332169/diff/10001/chrome/renderer/ch...
File chrome/renderer/chrome_render_view_observer.cc (right):

https://chromiumcodereview.appspot.com/10332169/diff/10001/chrome/renderer/ch...
chrome/renderer/chrome_render_view_observer.cc:498: ExtensionURLInfo(origin,
document.url()));
This doesn't seem to quite work. For windows created with window.open (or
chrome.appWindow.create) initially document.url is set to null (and then later
it gets updated). The security origin always has the right extension ID though.

[Mihai Parparita -not on Chrome, 2012-06-21 01:30:33]

On Wed, Jun 20, 2012 at 12:47 PM, <mihaip@chromium.org> wrote:

> This doesn't seem to quite work. For windows created with window.open
> (or chrome.appWindow.create) initially document.url is set to null (and
> then later it gets updated). The security origin always has the right
> extension ID though.
>

Sent out an attempted fix with
https://chromiumcodereview.appspot.com/10598006/

Mihai

[Hajime Morrita, 2012-06-21 01:34:51]

Good catch, and thanks for taking this.