Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 10332148: Convert the Bluetooth API to use ArrayBuffers. (Closed)

Created:
8 years, 7 months ago by bryeung
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Convert the Bluetooth API to use ArrayBuffers. TEST=still compiles BUG=119473 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137161

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M chrome/common/extensions/api/experimental_bluetooth.idl View 1 3 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bryeung
8 years, 7 months ago (2012-05-14 18:29:57 UTC) #1
asargent_no_longer_on_chrome
The changes to the idl file look fine - are these all for not-yet-implemented parts ...
8 years, 7 months ago (2012-05-14 22:23:57 UTC) #2
bryeung
Correct: these API functions have not been implemented yet (the CL for some of them ...
8 years, 7 months ago (2012-05-14 23:17:46 UTC) #3
asargent_no_longer_on_chrome
ok, lgtm
8 years, 7 months ago (2012-05-14 23:38:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/10332148/1
8 years, 7 months ago (2012-05-15 14:41:53 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/common/extensions/api/experimental.bluetooth.idl. While running patch -p1 --forward --force; patching file chrome/common/extensions/api/experimental.bluetooth.idl ...
8 years, 7 months ago (2012-05-15 14:41:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/10332148/6001
8 years, 7 months ago (2012-05-15 15:37:32 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 17:13:44 UTC) #8
Change committed as 137161

Powered by Google App Engine
This is Rietveld 408576698