aura/ash split: Moves RootWindowEventFilter and InputMethodEventFilter to ui/aura/.

aura/ash split: Moves RootWindowEventFilter and InputMethodEventFilter to ui/aura/.

All of InputMethodEventFilter and more than half of
RootWindowEventFilter were copied verbatim to a
DesktopRootWindowEventFilter. Instead of copying the other half for
another patch, I'm just moving RWEF and deleting the desktop version.

(InputMethodEventFilterUnittest was simple enough to move with the
file, but RootWindowEventFilter seems to act more like an integraiton
test of a lot of the stuff on Shell.)

BUG=125106
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137175

[Elliot Glaysher, 2012-05-14 18:09:52]

Minimize TestEventFilter.

[Elliot Glaysher, 2012-05-14 19:00:18]

ben: review move and possibly give advice if there's something I should do w/
root_window_event_filter_unittest.cc instead.

[Ben Goodger (Google), 2012-05-14 22:05:21]

https://chromiumcodereview.appspot.com/10332145/diff/4001/ui/aura/ime/input_m...
File ui/aura/ime/input_method_event_filter.h (right):

https://chromiumcodereview.appspot.com/10332145/diff/4001/ui/aura/ime/input_m...
ui/aura/ime/input_method_event_filter.h:5: #ifndef
UI_AURA_IME_INPUT_METHOD_EVENT_FILTER_H_
same here, i'd like this to go into client not aura itself. then i'd like there
to be DEPS that prevents src/ui/aura from including this.

https://chromiumcodereview.appspot.com/10332145/diff/4001/ui/aura/root_window...
File ui/aura/root_window_event_filter.h (right):

https://chromiumcodereview.appspot.com/10332145/diff/4001/ui/aura/root_window...
ui/aura/root_window_event_filter.h:6: #define
UI_AURA_ROOT_WINDOW_EVENT_FILTER_H_
so, instead of just moving this into aura... i'd put this in client. aura
doesn't know about active windows and i'd argue it shouldn't.

[Elliot Glaysher, 2012-05-14 22:55:01]

Moved to ui/aura/shared/

[Ben Goodger (Google), 2012-05-15 17:35:13]

Cool. Thanks for doing this. Just nits.

LGTM.

https://chromiumcodereview.appspot.com/10332145/diff/8001/ash/shell.cc
File ash/shell.cc (right):

https://chromiumcodereview.appspot.com/10332145/diff/8001/ash/shell.cc#newcod...
ash/shell.cc:519: Shell::TestApi::input_method_event_filter() {
nit indent 4 spaces

https://chromiumcodereview.appspot.com/10332145/diff/8001/ui/aura/shared/inpu...
File ui/aura/shared/input_method_event_filter.h (right):

https://chromiumcodereview.appspot.com/10332145/diff/8001/ui/aura/shared/inpu...
ui/aura/shared/input_method_event_filter.h:31:
InputMethodEventFilter(RootWindow* root_window);
explicit

https://chromiumcodereview.appspot.com/10332145/diff/8001/ui/aura/shared/inpu...
ui/aura/shared/input_method_event_filter.h:55: RootWindow* root_window_;   //
weak ptr
such ptrs are assumed weak unless scoped or otherwise noted.

https://chromiumcodereview.appspot.com/10332145/diff/8001/ui/aura/shared/root...
File ui/aura/shared/root_window_event_filter.h (right):

https://chromiumcodereview.appspot.com/10332145/diff/8001/ui/aura/shared/root...
ui/aura/shared/root_window_event_filter.h:23: // Additional event filters can be
added to RootWIndowEventFilter. Events will
RootWindowEventFilter

https://chromiumcodereview.appspot.com/10332145/diff/8001/ui/views/widget/des...
File ui/views/widget/desktop_native_widget_helper_aura.cc (right):

https://chromiumcodereview.appspot.com/10332145/diff/8001/ui/views/widget/des...
ui/views/widget/desktop_native_widget_helper_aura.cc:30: if
(root_window_event_filter_) {
nit no braces