WebSocket Pepper API: allow to close connection without code and reason

ppapi/tests/test_websocket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_websocket.h"
 
 #include <stdio.h>
 #include <string.h>
 
 #include <algorithm>
@@ skipping 449 matching lines @@
       callback.GetCallback().pp_completion_callback()));
   ASSERT_EQ(PP_ERROR_FAILED, callback.result());
   core_interface_->ReleaseResource(ws);
 
   // Close with bad arguments.
   int32_t result;
   ws = Connect(GetFullURL(kEchoServerURL), &result, "");
   ASSERT_TRUE(ws);
   ASSERT_EQ(PP_OK, result);
   callback.WaitForResult(websocket_interface_->Close(
-      ws, 1U, reason, callback.GetCallback().pp_completion_callback()));
+      ws, static_cast<PP_WebSocketStatusCode>(1), reason,
+      callback.GetCallback().pp_completion_callback()));
   ASSERT_EQ(PP_ERROR_NOACCESS, callback.result());
   core_interface_->ReleaseResource(ws);
 
   // Close with PP_VARTYPE_NULL.
   ws = Connect(GetFullURL(kEchoServerURL), &result, "");
   ASSERT_TRUE(ws);
   ASSERT_EQ(PP_OK, result);
   callback.WaitForResult(websocket_interface_->Close(
       ws, PP_WEBSOCKETSTATUSCODE_NORMAL_CLOSURE, PP_MakeNull(),
       callback.GetCallback().pp_completion_callback()));
@@ skipping 65 matching lines @@
   PP_Resource ws = Connect(GetFullURL(kEchoServerURL), &result, "");
   ASSERT_TRUE(ws);
   ASSERT_EQ(PP_OK, result);
   callback.WaitForResult(websocket_interface_->Close(
       ws, PP_WEBSOCKETSTATUSCODE_NORMAL_CLOSURE, reason,
       callback.GetCallback().pp_completion_callback()));
   CHECK_CALLBACK_BEHAVIOR(callback);
   ASSERT_EQ(PP_OK, callback.result());
   core_interface_->ReleaseResource(ws);
 
+  // Close without code and reason.
+  ws = Connect(GetFullURL(kEchoServerURL), &result, "");
+  ASSERT_TRUE(ws);
+  ASSERT_EQ(PP_OK, result);
+  callback.WaitForResult(websocket_interface_->Close(
+      ws, PP_WEBSOCKETSTATUSCODE_NOT_SPECIFIED, reason,
+      callback.GetCallback().pp_completion_callback()));
+  ASSERT_EQ(PP_OK, callback.result());
+  core_interface_->ReleaseResource(ws);
+
   // Close with PP_VARTYPE_UNDEFINED.
   ws = Connect(GetFullURL(kEchoServerURL), &result, "");
   ASSERT_TRUE(ws);
   ASSERT_EQ(PP_OK, result);
   callback.WaitForResult(websocket_interface_->Close(
       ws, PP_WEBSOCKETSTATUSCODE_NORMAL_CLOSURE, PP_MakeUndefined(),
       callback.GetCallback().pp_completion_callback()));
   CHECK_CALLBACK_BEHAVIOR(callback);
   ASSERT_EQ(PP_OK, callback.result());
   core_interface_->ReleaseResource(ws);
@@ skipping 601 matching lines @@
     ASSERT_EQ(0U, websocket.GetSeenEvents().size());
   }
 
   // Close with bad arguments.
   {
     TestWebSocketAPI websocket(instance_);
     int32_t result = websocket.Connect(pp::Var(GetFullURL(kEchoServerURL)),
         NULL, 0);
     ASSERT_EQ(PP_OK_COMPLETIONPENDING, result);
     websocket.WaitForConnected();
-    result = websocket.Close(1U, reason);
+    result = websocket.Close(static_cast<PP_WebSocketStatusCode>(1), reason);
     ASSERT_EQ(PP_ERROR_NOACCESS, result);
     const std::vector<WebSocketEvent>& events = websocket.GetSeenEvents();
     ASSERT_EQ(1U, events.size());
     ASSERT_EQ(WebSocketEvent::EVENT_OPEN, events[0].event_type);
   }
 
   PASS();
 }
 
 std::string TestWebSocket::TestUtilityValidClose() {
@@ skipping 209 matching lines @@
   size_t last_event = events_on_closed - 1;
   for (uint32_t i = 1; i < last_event; ++i) {
     ASSERT_EQ(WebSocketEvent::EVENT_MESSAGE, events[i].event_type);
     ASSERT_TRUE(AreEqualWithString(events[i].var.pp_var(), message));
   }
   ASSERT_EQ(WebSocketEvent::EVENT_CLOSE, events[last_event].event_type);
   ASSERT_TRUE(events[last_event].was_clean);
 
   PASS();
 }