Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 10332137: Add -d flag to grokdump to dump all available memory areas (Closed)

Created:
8 years, 7 months ago by Erik Corry
Modified:
8 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Add -f or --full flag to grokdump to dump all available memory areas from the minidump. Committed: https://code.google.com/p/v8/source/detail?r=11554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M tools/grokdump.py View 4 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
8 years, 7 months ago (2012-05-14 07:48:06 UTC) #1
Michael Starzinger
8 years, 7 months ago (2012-05-14 07:52:32 UTC) #2
LGTM. Only the description says it's -d whereas in the code it's -f.

Powered by Google App Engine
This is Rietveld 408576698