Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 10332125: Make ppapi_shared depend on gles2_utils. (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Make ppapi_shared depend on gles2_utils. Without this, linking libppapi_shared.dylib on mac in a debug build fails with "__ZN3gpu5gles29GLES2Util25GetStringProgramParameterEj", referenced from: __ZN3gpu5gles219GLES2Implementation12GetProgramivEjjPi in ppapi_shared.ppb_opengles2_shared.o "__ZN3gpu5gles29GLES2Util16GetStringGLStateEj", referenced from: __ZN3gpu5gles219GLES2Implementation11GetIntegervEjPi in ppapi_shared.ppb_opengles2_shared.o __ZN3gpu5gles219GLES2Implementation9GetFloatvEjPf in ppapi_shared.ppb_opengles2_shared.o __ZN3gpu5gles219GLES2Implementation11GetBooleanvEjPh in ppapi_shared.ppb_opengles2_shared.o "__ZN3gpu5gles29GLES2Util19GetStringShaderTypeEj", referenced from: __ZN3gpu5gles219GLES2Implementation12CreateShaderEj in ppapi_shared.ppb_opengles2_shared.o BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ppapi/ppapi_shared.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
"""Suggested OWNERS: viettrungluu@chromium.org """
8 years, 7 months ago (2012-05-11 20:48:24 UTC) #1
viettrungluu
lgtm
8 years, 7 months ago (2012-05-11 21:00:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10332125/1
8 years, 7 months ago (2012-05-11 21:02:25 UTC) #3
commit-bot: I haz the power
Try job failure for 10332125-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-11 22:29:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10332125/1
8 years, 7 months ago (2012-05-11 22:30:24 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-12 01:12:11 UTC) #6
Change committed as 136733

Powered by Google App Engine
This is Rietveld 408576698