Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 10332101: Fix for Issue 915 (Closed)

Created:
8 years, 7 months ago by Peter Rybin
Modified:
8 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix test status #

Patch Set 3 : clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -49 lines) Patch
M src/liveedit.cc View 1 2 3 chunks +15 lines, -43 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Rybin
Hi Erik Do you think it looks like a fix for http://code.google.com/p/v8/issues/detail?id=915 ? Peter
8 years, 7 months ago (2012-05-10 21:20:16 UTC) #1
Peter Rybin
I also added fix to mjsunit.status for this fix.
8 years, 7 months ago (2012-05-14 21:21:28 UTC) #2
Peter Rybin
ping
8 years, 7 months ago (2012-05-21 17:35:21 UTC) #3
Erik Corry
In order to avoid problems with the incremental marker you could ensure that a GC ...
8 years, 7 months ago (2012-05-22 10:39:53 UTC) #4
Peter Rybin
8 years, 6 months ago (2012-06-14 23:37:46 UTC) #5
On 2012/05/22 10:39:53, Erik Corry wrote:
> In order to avoid problems with the incremental marker you could ensure that a
> GC is completed immediately before doing the replacement.  See the code in
> HeapSnapshotsCollection::FindHeapObjectById for an example.
> 
> LGTM

Thank you for advice.

Actually I'm fine with patching dead objects amongst others. Is it the only
thing I should be caring about? In this case probably it's not required to do
extra GC.

Powered by Google App Engine
This is Rietveld 408576698