Issue 10332091: Fix override of LocationProviderBase::OnPermissionGranted() in LocationProviderAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332091: Fix override of LocationProviderBase::OnPermissionGranted() in LocationProviderAndroid (Closed)

Created:
8 years, 7 months ago by Steve Block

Modified:
8 years, 7 months ago

Reviewers:
bartfab (slow), John Knottenbelt

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, John Knottenbelt

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix override of LocationProviderBase::OnPermissionGranted() in LocationProviderAndroid See http://codereview.chromium.org/10107017 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136307

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	content/browser/geolocation/location_provider_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/geolocation/location_provider_android.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

bartfab (slow)

This is obviously the right thing to do, getting back in sync after I removed ...

8 years, 7 months ago (2012-05-10 15:26:19 UTC) #2

lgtm. Thanks Steve!