tools/gypv8sh.py - Issue 10332081: gypv8sh; only catch CalledProcessException, rather than Exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gypv8sh.py

Issue 10332081: gypv8sh; only catch CalledProcessException, rather than Exception (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gypv8sh.py

diff --git a/tools/gypv8sh.py b/tools/gypv8sh.py

index 7018db91f34d019fd459a672bcba71502c3b9889..7f4a7b545a76817422aed0782a78ef0c36b51be9 100755

--- a/tools/gypv8sh.py

+++ b/tools/gypv8sh.py

@@ -44,7 +44,8 @@ def main ():

try:

subprocess.check_call(cmd, stdout=open(cxxoutfile, 'w'))

shutil.copyfile(inputfile, jsoutfile)

- except Exception, ex:

+ except subprocess.CalledProcessException, ex:

+ print "returncode", ex.returncode

print ex

os.remove(cxxoutfile)

os.remove(jsoutfile)

« no previous file with comments | « no previous file | no next file » | no next file with comments »