Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 10332081: gypv8sh; only catch CalledProcessException, rather than Exception (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Sheridan Rawlins
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

The try around subprocess.check_call catches Exception. Instead catch CalledProcessException so that other exceptions aren't swallowed. Due to a confluence of other problems, this was eating an exception that subprocess was raising before actually starting the subprocess. ref: http://docs.python.org/library/subprocess.html#subprocess.check_call R=scr@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gypv8sh.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
8 years, 7 months ago (2012-05-09 22:48:32 UTC) #1
Sheridan Rawlins
8 years, 7 months ago (2012-05-18 21:05:46 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698