Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 10332074: Update sdch's config.h for Android (Closed)

Created:
8 years, 7 months ago by Steve Block
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Peter Beverloo, wtc, Hao Zheng, Torne
Visibility:
Public.

Description

Update sdch's config.h for Android Avoid redefining HAVE_MALLOC_H, which is already defined in Android's AndroidConfig.h. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136333

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use existing linux/config.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M sdch/linux/config.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Steve Block
For reviewing convenience ... $ diff sdch/linux/config.h sdch/android/config.h 1,2c1 < /* src/config.h. Generated from config.h.in ...
8 years, 7 months ago (2012-05-09 14:33:52 UTC) #1
wtc
Drive-by review comments on patch set 1: I think this CL is fine. But we ...
8 years, 7 months ago (2012-05-09 19:26:47 UTC) #2
jar (doing other things)
http://codereview.chromium.org/10332074/diff/1/sdch/android/config.h File sdch/android/config.h (right): http://codereview.chromium.org/10332074/diff/1/sdch/android/config.h#newcode111 sdch/android/config.h:111: #if defined(__i386__) || defined(__x86_64__) +1 Can you take that ...
8 years, 7 months ago (2012-05-10 06:40:14 UTC) #3
Steve Block
8 years, 7 months ago (2012-05-10 14:10:02 UTC) #4
jar (doing other things)
This L G T M..... but I'll let wtc concur, since he is more familiar ...
8 years, 7 months ago (2012-05-10 16:17:15 UTC) #5
wtc
8 years, 7 months ago (2012-05-10 16:58:28 UTC) #6
Patch set 2 LGTM.  Thanks.

Powered by Google App Engine
This is Rietveld 408576698