Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 10332071: Pass command line arguments onto platform apps which provide the right intent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Windows tests fixed Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/ash/extension_utils.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
index 7cf5db83048ed5e3dac062a499658fd231ae49b7..212b64f0b3deb9164a05c534ad543cbd962524f1 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
@@ -545,12 +545,13 @@ void AppLauncherHandler::HandleLaunchApp(const ListValue* args) {
if (disposition == NEW_FOREGROUND_TAB || disposition == NEW_BACKGROUND_TAB) {
// TODO(jamescook): Proper support for background tabs.
application_launch::OpenApplication(
- profile, extension, extension_misc::LAUNCH_TAB, GURL(url), disposition);
+ profile, extension, extension_misc::LAUNCH_TAB, GURL(url), disposition,
+ NULL);
} else if (disposition == NEW_WINDOW) {
// Force a new window open.
application_launch::OpenApplication(
profile, extension, extension_misc::LAUNCH_WINDOW, GURL(url),
- disposition);
+ disposition, NULL);
} else {
// Look at preference to find the right launch container. If no preference
// is set, launch as a regular tab.
@@ -567,7 +568,7 @@ void AppLauncherHandler::HandleLaunchApp(const ListValue* args) {
WebContents* new_contents = application_launch::OpenApplication(
profile, extension, launch_container, GURL(url),
- old_contents ? CURRENT_TAB : NEW_FOREGROUND_TAB);
+ old_contents ? CURRENT_TAB : NEW_FOREGROUND_TAB, NULL);
// This will also destroy the handler, so do not perform any actions after.
if (new_contents != old_contents && browser && browser->tab_count() > 1)
« no previous file with comments | « chrome/browser/ui/views/ash/extension_utils.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698