Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3295)

Unified Diff: chrome/browser/ui/extensions/application_launch.h

Issue 10332071: Pass command line arguments onto platform apps which provide the right intent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Windows tests fixed Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/extensions/application_launch.h
diff --git a/chrome/browser/ui/extensions/application_launch.h b/chrome/browser/ui/extensions/application_launch.h
index 7bb3dcc873e747e62f679b6d74f1f7c3625c6a9f..5b9627a7651e43b51fdd8804778619d55a40319c 100644
--- a/chrome/browser/ui/extensions/application_launch.h
+++ b/chrome/browser/ui/extensions/application_launch.h
@@ -10,6 +10,7 @@
#include "webkit/glue/window_open_disposition.h"
class Browser;
+class CommandLine;
class GURL;
class Profile;
@@ -25,12 +26,17 @@ namespace application_launch {
// Open |extension| in |container|, using |disposition| if container type is
// TAB. Returns the WebContents* that was created or NULL. If non-empty,
-// |override_url| is used in place of the app launch url.
+// |override_url| is used in place of the app launch url. Pass relevant
+// information in |command_line| onto platform app as launch data.
+// |command_line| can be NULL, indicating there is no launch data to pass on.
+// TODO(benwells): Put the parameters to this into an ApplicationLaunchParams
+// struct.
content::WebContents* OpenApplication(Profile* profile,
const extensions::Extension* extension,
extension_misc::LaunchContainer container,
const GURL& override_url,
- WindowOpenDisposition disposition);
+ WindowOpenDisposition disposition,
+ const CommandLine* command_line);
#if defined(USE_ASH)
// Opens |url| in a new application panel window for the specified url.
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698