Make sure only the main browser process and service proceses are allowed to create the profile dire…

chrome/common/chrome_paths.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_paths.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/sys_info.h"
 #include "base/version.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
+#include "content/public/common/content_switches.h"
 
 #if defined(OS_MACOSX)
 #include "base/mac/mac_util.h"
 #endif
 
 namespace {
 
 // File name of the internal Flash plugin on different platforms.
 const FilePath::CharType kInternalFlashPluginFileName[] =
 #if defined(OS_MACOSX)
@@ skipping 108 matching lines @@
     case chrome::FILE_RESOURCE_MODULE:
       return PathService::Get(base::FILE_MODULE, result);
   }
 
   // Assume that we will not need to create the directory if it does not exist.
   // This flag can be set to true for the cases where we want to create it.
   bool create_dir = false;
 
   FilePath cur;
   switch (key) {
-    case chrome::DIR_USER_DATA:
+    case chrome::DIR_USER_DATA: {
+      CommandLine *cmd_line = CommandLine::ForCurrentProcess();
+      if (cmd_line) {
+        // In some tests this check might be happening after the CommandLine
+        // object has been destroyed. This is DCHECKED but in release builds
+        // it might lead to a crash here.
+        CHECK(ProcessNeedsProfileDir(cmd_line->GetSwitchValueASCII(
+            switches::kProcessType)));
+      }
       if (!GetDefaultUserDataDirectory(&cur)) {
         NOTREACHED();
         return false;
       }
       create_dir = true;
       break;
+    }
     case chrome::DIR_USER_DOCUMENTS:
       if (!GetUserDocumentsDirectory(&cur))
         return false;
       create_dir = true;
       break;
     case chrome::DIR_DEFAULT_DOWNLOADS_SAFE:
 #if defined(OS_WIN) || defined(OS_LINUX)
       if (!GetUserDownloadsDirectorySafe(&cur))
         return false;
       break;
@@ skipping 257 matching lines @@
   return true;
 }
 
 // This cannot be done as a static initializer sadly since Visual Studio will
 // eliminate this object file if there is no direct entry point into it.
 void RegisterPathProvider() {
   PathService::RegisterProvider(PathProvider, PATH_START, PATH_END);
 }
 
 }  // namespace chrome