Issue 10332051: Revert "Do not consume Shift+Alt in Ash to make Chromoting happy."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332051: Revert "Do not consume Shift+Alt in Ash to make Chromoting happy." (Closed)

Created:
8 years, 7 months ago by Yusuke Sato

Modified:
8 years, 7 months ago

Reviewers:
Daniel Erat, Wez

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Do not consume Shift+Alt in Ash to make Chromoting happy." This reverts commit 0b0a3d32273ec42dba93f080495ca798fb2d5406 (r132748). Since a real fix for crbug.com/123720 has just been submitted (r135791), the workaround is no longer necessary. BUG=123720 TBR=derat@chromium.org TBR=wez@chromium.org TEST=manual (see the bug) and aura_shell_unittests Tests-Missing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135795

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	ash/accelerators/accelerator_controller.cc	View		1 chunk	+2 lines, -7 lines	0 comments	Download
	M	ash/accelerators/accelerator_controller_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Wez

8 years, 7 months ago (2012-05-14 21:36:17 UTC) #3

On 2012/05/08 13:51:25, Daniel Erat wrote:
> lgtm

Rubber-stamp LGTM, FWIW.

Expand Messages | Collapse Messages