Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 10332024: [cros] Show release notes in app window + restore sesssion. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove flag, add browser_defaults const Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/defaults.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index cfa6afd8052dde9c5886a1645a8ee22726e64715..241d778584c1136693dcf40aa9382bd2e92abe9b 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -42,6 +42,7 @@
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/net/gaia/google_service_auth_error.h"
#include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/dbus/session_manager_client.h"
#include "content/public/browser/browser_thread.h"
@@ -740,6 +741,9 @@ void ExistingUserController::InitializeStartUrls() const {
if (!guide_url.empty()) {
CommandLine::ForCurrentProcess()->AppendSwitchASCII(switches::kApp,
guide_url);
+ // NTP would open in the background, app window with GSG would be focused
+ // so that user won't have an empty desktop after GSG is closed.
+ CommandLine::ForCurrentProcess()->AppendArg(chrome::kChromeUINewTabURL);
} else {
// We should not be adding any start URLs if guide
// is defined as it launches as a standalone app window.
@@ -819,9 +823,8 @@ void ExistingUserController::OptionallyShowReleaseNotes(
if (current_version.components()[0] > prev_version.components()[0]) {
std::string release_notes_url = GetGettingStartedGuideURL();
if (!release_notes_url.empty()) {
- // TODO(nkostylev): Ideally we'd want to show this in app window
- // but passing --app=<url> would ignore session restore.
- CommandLine::ForCurrentProcess()->AppendArg(release_notes_url);
+ CommandLine::ForCurrentProcess()->AppendSwitchASCII(switches::kApp,
+ release_notes_url);
prefs->SetString(prefs::kChromeOSReleaseNotesVersion,
current_version.GetString());
}
« no previous file with comments | « no previous file | chrome/browser/defaults.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698