Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 10332018: Work around linker error of multiple definitions of pp::BlockUntilComplete (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, viettrungluu
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Work around linker error of multiple definitions of pp::BlockUntilComplete. BUG=121561 R=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135429

Patch Set 1 #

Patch Set 2 : remove .cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M ppapi/cpp/completion_callback.h View 1 chunk +5 lines, -1 line 0 comments Download
D ppapi/cpp/completion_callback.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
8 years, 7 months ago (2012-05-04 20:07:31 UTC) #1
brettw
lgtm
8 years, 7 months ago (2012-05-04 20:12:50 UTC) #2
scottmg
8 years, 7 months ago (2012-05-04 20:17:30 UTC) #3
the cl includes deleting ppapi/cpp/completion_callback.cc too, but git cl seems
unable to upload that.

Powered by Google App Engine
This is Rietveld 408576698