ui/gfx/platform_font_win.cc - Issue 10332002: win: Fix a few minor issues found by clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/platform_font_win.cc

Issue 10332002: win: Fix a few minor issues found by clang. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/platform_font_win.cc

diff --git a/ui/gfx/platform_font_win.cc b/ui/gfx/platform_font_win.cc

index c84b884af8862ce3f94882e0c044178973d04d8f..a9a7a43faf5f6ec43d5f3ab7ff03029c19195773 100644

--- a/ui/gfx/platform_font_win.cc

+++ b/ui/gfx/platform_font_win.cc

@@ -222,7 +222,7 @@ PlatformFontWin::HFontRef* PlatformFontWin::CreateHFontRef(HFONT font) {

{

base::win::ScopedGetDC screen_dc(NULL);

- base::win::ScopedSelectObject font(screen_dc, font);

+ base::win::ScopedSelectObject scoped_font(screen_dc, font);

Nico 2012/05/02 17:34:35 This one might actually fix a bug.

ui::ScopedSetMapMode mode(screen_dc, MM_TEXT);

GetTextMetrics(screen_dc, &font_metrics);

}