win: Fix a few minor issues found by clang.

crypto/rsa_private_key_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/rsa_private_key.h"
 
 #include <list>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_util.h"
 
 #pragma comment(lib, "crypt32.lib")
 
 namespace {
   // Helper for error handling during key import.
 #define READ_ASSERT(truth) \
   if (!(truth)) { \
   NOTREACHED(); \
-  return false; \
+  return NULL; \

[Ryan Sleevi, 2012/05/02 18:11:30]

Given there is only one instance of this macro, can you just remove the macro
and update the callsite?

[Nico, 2012/05/02 18:14:20]

Done.

   }
 }  // namespace
 
 namespace crypto {
 
 // static
 RSAPrivateKey* RSAPrivateKey::Create(uint16 num_bits) {
   scoped_ptr<RSAPrivateKey> result(new RSAPrivateKey);
   if (!result->InitProvider())
     return NULL;
@@ skipping 201 matching lines @@
       &encoded_length)) {
     NOTREACHED();
     return false;
   }
 
   output->assign(encoded.get(), encoded.get() + encoded_length);
   return true;
 }
 
 }  // namespace crypto