Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 10331005: Revert 115549 - Ensure that there's always a provisional document loader if the frame loader is in … (Closed)

Created:
8 years, 7 months ago by karen
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1123/
Visibility:
Public.

Description

Revert 115549 - Ensure that there's always a provisional document loader if the frame loader is in provisional state https://bugs.webkit.org/show_bug.cgi?id=83894 Reviewed by Nate Chapin. We're still seeing crashes in the FrameLoader where the FrameLoader's state is "provisional" but there is no provisional document loader. I added code to update the FrameLoader's state everytime the provisional document loader is cleared, and added checks that the FrameLoader's state can't be set to provisional without a provisional loader. If the crashes go away, or the newly added checks reveal the culprit, we should relex the checks to use ASSERT() instead of CRASH(). * loader/FrameLoader.cpp: (WebCore::FrameLoader::init): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=115916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M Source/WebCore/loader/FrameLoader.cpp View 6 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 7 months ago (2012-05-03 00:17:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698