Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 103213015: Pass through the parent_tab_id when creating a new tab. (Closed)

Created:
6 years, 11 months ago by aurimas (slooooooooow)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, marja+watch_chromium.org
Visibility:
Public.

Description

Pass through the parent_tab_id when creating a new tab. BUG=328080 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243424

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated the unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/sessions/session_restore_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
aurimas (slooooooooow)
Hey David, Please take a look at this CL. Thanks, Aurimas
6 years, 11 months ago (2014-01-07 17:32:07 UTC) #1
aurimas (slooooooooow)
dtrainor@chromium.org: Please review changes
6 years, 11 months ago (2014-01-07 19:11:42 UTC) #2
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/103213015/diff/1/chrome/browser/sessions/session_restore_android.cc File chrome/browser/sessions/session_restore_android.cc (right): https://chromiumcodereview.appspot.com/103213015/diff/1/chrome/browser/sessions/session_restore_android.cc#newcode42 chrome/browser/sessions/session_restore_android.cc:42: TabAndroid* current_tab = TabAndroid::FromWebContents(web_contents); Are we sure this ...
6 years, 11 months ago (2014-01-07 19:29:29 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/103213015/diff/1/chrome/browser/sessions/session_restore_android.cc File chrome/browser/sessions/session_restore_android.cc (right): https://chromiumcodereview.appspot.com/103213015/diff/1/chrome/browser/sessions/session_restore_android.cc#newcode42 chrome/browser/sessions/session_restore_android.cc:42: TabAndroid* current_tab = TabAndroid::FromWebContents(web_contents); On 2014/01/07 19:29:30, David Trainor ...
6 years, 11 months ago (2014-01-07 19:41:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/103213015/80001
6 years, 11 months ago (2014-01-07 23:05:05 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 23:07:20 UTC) #6
Message was sent while issue was closed.
Change committed as 243424

Powered by Google App Engine
This is Rietveld 408576698