Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10320002: cros: Use touch theme assets with --touch-optimized-ui (Closed)

Created:
8 years, 7 months ago by James Cook
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

cros: Use touch theme assets with --touch-optimized-ui This follows the same pattern for theme_resources_touch_1x as we used for ui_resources_touch. I also introduced a gyp flag for enable_touch_ui at sky's suggestion. BUG=115234 TEST=visual, run with --touch-optimized-ui and see bigger tabstrip and toolbar assets Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134942

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M build/common.gypi View 5 chunks +11 lines, -0 lines 2 comments Download
M chrome/chrome_resources.gyp View 3 chunks +3 lines, -12 lines 0 comments Download
M chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/chromeos/autotest/files/client/deps/pyauto_dep/setup_test_links.sh View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/resource/resource_bundle_aurax11.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
James Cook
Sky, PTAL.
8 years, 7 months ago (2012-05-02 15:44:41 UTC) #1
sky
http://codereview.chromium.org/10320002/diff/2001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10320002/diff/2001/build/common.gypi#newcode105 build/common.gypi:105: 'enable_touch_ui%': 1, Are you sure you want to set ...
8 years, 7 months ago (2012-05-02 16:12:20 UTC) #2
James Cook
http://codereview.chromium.org/10320002/diff/2001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10320002/diff/2001/build/common.gypi#newcode105 build/common.gypi:105: 'enable_touch_ui%': 1, On 2012/05/02 16:12:21, sky wrote: > Are ...
8 years, 7 months ago (2012-05-02 16:22:20 UTC) #3
sky
On Wed, May 2, 2012 at 9:22 AM, <jamescook@chromium.org> wrote: > > http://codereview.chromium.org/10320002/diff/2001/build/common.gypi > File ...
8 years, 7 months ago (2012-05-02 16:31:09 UTC) #4
James Cook
On 2012/05/02 16:31:09, sky wrote: > On Wed, May 2, 2012 at 9:22 AM, <mailto:jamescook@chromium.org> ...
8 years, 7 months ago (2012-05-02 16:34:59 UTC) #5
sky
Perfect, LGTM
8 years, 7 months ago (2012-05-02 16:42:23 UTC) #6
James Cook
On 2012/05/02 16:42:23, sky wrote: > Perfect, LGTM Oops, did you mean perfect as-is or ...
8 years, 7 months ago (2012-05-02 20:02:49 UTC) #7
sky
8 years, 7 months ago (2012-05-02 21:05:15 UTC) #8
Perfect as is.

On Wed, May 2, 2012 at 1:02 PM,  <jamescook@chromium.org> wrote:
> On 2012/05/02 16:42:23, sky wrote:
>>
>> Perfect, LGTM
>
>
> Oops, did you mean perfect as-is or perfect assuming I rename the flag to
> 'include_touch_assets'?  I committed it with the name 'enable_touch_ui' - do
> you
> think I should change it?
>
>
> http://codereview.chromium.org/10320002/

Powered by Google App Engine
This is Rietveld 408576698