runtime/vm/code_generator_ia32.h - Issue 10317026: Inline type checks for complex uninstantiated types, e.g., List<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator_ia32.h

Issue 10317026: Inline type checks for complex uninstantiated types, e.g., List<T>. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator_ia32.h

===================================================================

--- runtime/vm/code_generator_ia32.h (revision 7346)

+++ runtime/vm/code_generator_ia32.h (working copy)

@@ -180,7 +180,8 @@

void GenerateArgumentTypeChecks();

void GenerateConditionTypeCheck(intptr_t node_id, intptr_t token_index);

- void GenerateInstantiatorTypeArguments(intptr_t token_index);

+ void GenerateInstantiatorTypeArguments(intptr_t token_index,

+ bool push_instantiator);

void GenerateTypeArguments(intptr_t node_id,

intptr_t token_index,

const AbstractTypeArguments& type_arguments,

@@ -206,7 +207,7 @@

Label* is_instance_lbl,

Label* is_not_instance_lbl);

- RawSubtypeTestCache* GenerateInstantiatedTypeWithArgumentsTest(

+ RawSubtypeTestCache* GenerateInstantiatedTypeWithArgumentsTest(

intptr_t node_id,

intptr_t token_index,

const AbstractType& dst_type,

@@ -217,9 +218,12 @@

const AbstractType& dst_type,

Label* is_instance_lbl,

Label* is_not_instance_lbl);

- void GenerateUninstantiatedTypeTest(const AbstractType& dst_type,

- intptr_t token_index,

- Label* is_instance_lbl);

+ RawSubtypeTestCache* GenerateUninstantiatedTypeTest(

+ const AbstractType& dst_type,

+ intptr_t node_id,

+ intptr_t token_index,

+ Label* is_instance_lbl,

+ Label* is_not_instance_label);

RawSubtypeTestCache* GenerateSubtype1TestCacheLookup(

intptr_t node_id,

intptr_t token_index,

« runtime/vm/code_generator.cc ('K') | « runtime/vm/code_generator.cc ('k') | runtime/vm/code_generator_ia32.cc » ('j') | runtime/vm/code_generator_ia32.cc » ('J')