Inline type checks for complex uninstantiated types, e.g., List<T>.

runtime/vm/flow_graph_compiler_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 324 matching lines @@
 
   // Generate inline type check, linking to runtime call if not assignable.
   GenerateInlineInstanceof(dst_type, &is_assignable, &runtime_call);
 
   __ Bind(&runtime_call);
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
   __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
   __ pushq(Immediate(Smi::RawValue(cid)));  // Computation id.
   __ pushq(RAX);  // Push the source object.
   __ PushObject(dst_type);  // Push the type of the destination.
-  if (!dst_type.IsInstantiated()) {
+  __ pushq(raw_null);  // TODO(srdjan): Instantiator.
+  if (dst_type.IsInstantiated()) {
+    __ pushq(raw_null);  // Null instantiator type arguments.
+  } else {
     __ pushq(RDX);  // Instantiator type arguments.
-  } else {
-    __ pushq(raw_null);  // Null instantiator.
   }
   __ PushObject(dst_name);  // Push the name of the destination.
   __ pushq(raw_null);  // SubtypeTestCache not yet supported.
   GenerateCallRuntime(cid,
                       token_index,
                       try_index,
                       kTypeCheckRuntimeEntry);
   // Pop the parameters supplied to the runtime entry. The result of the
   // type check runtime call is the checked value.
-  __ addq(RSP, Immediate(7 * kWordSize));
+  __ addq(RSP, Immediate(8 * kWordSize));
   __ popq(RAX);
 
   __ Bind(&is_assignable);
 }
 
 
 void FlowGraphCompiler::LoadValue(Register dst, Value* value) {
   if (value->IsConstant()) {
     ConstantVal* constant = value->AsConstant();
     if (constant->value().IsSmi()) {
@@ skipping 463 matching lines @@
 
   // Generate inline instanceof test.
   GenerateInlineInstanceof(type, &is_instance, &is_not_instance);
 
   // Generate runtime call.
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
   __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
   __ pushq(Immediate(Smi::RawValue(cid)));  // Computation id.
   __ pushq(RAX);  // Push the instance.
   __ PushObject(type);  // Push the type.
-  if (!type.IsInstantiated()) {
+  __ pushq(raw_null);  // TODO(srdjan): Pass instantiator instead of null.
+  if (type.IsInstantiated()) {
+    __ pushq(raw_null);  // Null instantiator type arguments.
+  } else {
     __ pushq(RDX);  // Instantiator type arguments.
-  } else {
-    __ pushq(raw_null);  // Null instantiator.
   }
   __ pushq(raw_null);  // SubtypeTestCache not yet supported.
   GenerateCallRuntime(cid, token_index, try_index, kInstanceofRuntimeEntry);
   // Pop the two parameters supplied to the runtime entry. The result of the
   // instanceof runtime call will be left as the result of the operation.
-  __ addq(RSP, Immediate(6 * kWordSize));
+  __ addq(RSP, Immediate(7 * kWordSize));
   Label done;
   if (negate_result) {
     __ popq(RDX);
     __ LoadObject(RAX, bool_true);
     __ cmpq(RDX, RAX);
     __ j(NOT_EQUAL, &done, Assembler::kNearJump);
     __ LoadObject(RAX, bool_false);
   } else {
     __ popq(RAX);
   }
@@ skipping 861 matching lines @@
   ASSERT(exception_handlers_list_ != NULL);
   const ExceptionHandlers& handlers = ExceptionHandlers::Handle(
       exception_handlers_list_->FinalizeExceptionHandlers(code.EntryPoint()));
   code.set_exception_handlers(handlers);
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64