Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 10317012: windows: test that \ at end of action arg doesn't work (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

windows: test that \ at end of action arg doesn't work Addition of test here http://codereview.chromium.org/10371002/ discovered that VS doesn't support an action's argument ending in \ (because it escapes the quote that's implicitly added around arguments). So, change one of those previously added tests to intended failure, and simplify escaping in ninja to not do the extra escape of trailing \s. (Sigh.) R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 chunk +0 lines, -5 lines 0 comments Download
M test/win/gyptest-macro-vcinstalldir.py View 1 chunk +3 lines, -1 line 0 comments Download
M test/win/vs-macros/vcinstalldir.gyp View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
8 years, 7 months ago (2012-05-04 02:58:18 UTC) #1
Nico
8 years, 7 months ago (2012-05-04 03:15:05 UTC) #2
Lgtm

At least the test approach seems to work pretty well :-)

Powered by Google App Engine
This is Rietveld 408576698