Make the Geoposition helper class public

Make the Geoposition helper struct public

This CL moves the Geoposition struct from content/common to public/content/common.h so that it can be shared by content and browser. The struct is placed in the |content| namespace and as required by the style guide, all methods except the constructor and Validate() are removed.
This paves the way for a follow-up CL in which the content will provide geolocation information to the browser.

BUG=chromium-os:18710
TEST=Chrome and tests build, run

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134989

[bartfab (slow), 2012-05-02 14:34:43]

Hi John,

As discussed, I broke my changes into several CLs. This first one moves the
geolocation.h header to make it public.

[jam, 2012-05-02 14:55:08]

few comments
-now that this is public, content/public/browser/geolocation.h should use it
-we're strict in the Content API about following the Google style guide, which
this class doesn't. some of the issues are that it's a struct with methods
(disallowed), and that methods that are implemented in the cc file have
unix_hacker() names. if these methods are only called in one place, then perhaps
take them out. otherwise this needs to be turned into a class.

it's better if you can keep this a struct, because we don't keep concrete
classes in content/public, so you'll have to have an interface and an
implementation in content/browser

[bartfab (slow), 2012-05-02 17:27:40]

Hi John, I addressed your comments. The Geolocation struct should not only
contain methods explicitly allowed by the style guide now. Could you have
another look?

[jam, 2012-05-02 18:04:23]

lgtm with one comment

http://codereview.chromium.org/10316007/diff/4001/content/public/common/geopo...
File content/public/common/geoposition.h (right):

http://codereview.chromium.org/10316007/diff/4001/content/public/common/geopo...
content/public/common/geoposition.h:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
for this and the cc file, please "svn mv" them and not just copy them yourself
and "svn add" them, so that we maintain the svn history.

[commit-bot: I haz the power, 2012-05-02 18:58:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/10316007/10001

[commit-bot: I haz the power, 2012-05-02 18:58:57]

Presubmit check for 10316007-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  content/browser/geolocation/geolocation.cc:23
    GeolocationProvider::GetInstance()->OverrideLocationForTesting(position); \
  content/browser/geolocation/geolocation.cc:29
    void OverrideLocationForTesting(

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  content/browser/geolocation/geolocation_provider.h, line 54, 81 chars

Presubmit checks took 5.7s to calculate.

[commit-bot: I haz the power, 2012-05-02 19:02:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/10316007/13001

[commit-bot: I haz the power, 2012-05-02 19:18:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/10316007/13003

[commit-bot: I haz the power, 2012-05-02 20:48:40]

Change committed as 134989