Added base::win::InitializeWindowClass() wrapper to make sure that window classes are properly asso…

base/message_pump_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_pump_win.h"
 
 #include <math.h>
 
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
-#include "base/process_util.h"
 #include "base/stringprintf.h"
 #include "base/win/wrapped_window_proc.h"
 
 namespace {
 
 // The ID of the timer used by the UI message pump.
 const int kMessagePumpTimerId = 0;
 
 }  // namespace
 
@@ skipping 224 matching lines @@
     if (more_work_is_plausible)
       continue;
 
     WaitForWork();  // Wait (sleep) until we have work to do again.
   }
 }
 
 void MessagePumpForUI::InitMessageWnd() {
   // Register a unique window class for each instance of UI pump.
   string16 class_name = base::StringPrintf(kWndClassFormat, this);
-  WNDPROC window_procedure = &base::win::WrappedWindowProc<WndProcThunk>;
-
-  // RegisterClassEx uses a handle of the module containing the window procedure
-  // to distinguish identically named classes registered in different modules.
-  instance_ = GetModuleFromAddress(window_procedure);
-
-  WNDCLASSEXW wc = {0};
-  wc.cbSize = sizeof(wc);
-  wc.lpfnWndProc = window_procedure;
-  wc.hInstance = instance_;
-  wc.lpszClassName = class_name.c_str();
-  atom_ = RegisterClassEx(&wc);
+  WNDCLASSEX window_class;
+  base::win::InitializeWindowClass(
+      class_name.c_str(),
+      &base::win::WrappedWindowProc<WndProcThunk>,
+      0, 0, 0, NULL, NULL, NULL, NULL, NULL,
+      &window_class);
+  instance_ = window_class.hInstance;
+  atom_ = RegisterClassEx(&window_class);
   if (atom_ == 0) {
     DCHECK(atom_);
     return;
   }
 
   // Create the message-only window.
   message_hwnd_ = CreateWindow(
-      reinterpret_cast<const char16*>(atom_), 0, 0, 0, 0, 0, 0, HWND_MESSAGE, 0,
-      instance_, 0);
+      MAKEINTATOM(atom_), 0, 0, 0, 0, 0, 0, HWND_MESSAGE, 0, instance_, 0);
   if (message_hwnd_ == NULL) {
     DCHECK(message_hwnd_);
     return;
   }
 
   // Store |this| so that the window procedure could retrieve it later.
   SetWindowLongPtr(message_hwnd_,
                    GWLP_USERDATA,
                    reinterpret_cast<LONG_PTR>(this));
 }
@@ skipping 328 matching lines @@
 
 void MessagePumpForIO::WillProcessIOEvent() {
   FOR_EACH_OBSERVER(IOObserver, io_observers_, WillProcessIOEvent());
 }
 
 void MessagePumpForIO::DidProcessIOEvent() {
   FOR_EACH_OBSERVER(IOObserver, io_observers_, DidProcessIOEvent());
 }
 
 }  // namespace base