Issue 10315009: Modify two regression tests to actually fail when failing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10315009: Modify two regression tests to actually fail when failing. (Closed)

Created:
8 years, 7 months ago by Yang

Modified:
8 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Modify two regression tests to actually fail when failing. BUG= TEST=regress-1639, regress-1639-2 Committed: https://code.google.com/p/v8/source/detail?r=11493

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	test/mjsunit/regress/regress-1639.js	View	1	4 chunks	+14 lines, -8 lines	0 comments	Download
	M	test/mjsunit/regress/regress-1639-2.js	View		4 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 7 months ago (2012-05-03 11:51:20 UTC) #2

LGTM (with one comment).

https://chromiumcodereview.appspot.com/10315009/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-1639.js (right):

https://chromiumcodereview.appspot.com/10315009/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-1639.js:89: assertFalse(exception); // BREAK 3
Could we have some kind of NOP statement that actually triggers "Break 3" here,
and then the assertion, so that we don't break on the assertion itself?

Expand Messages | Collapse Messages