Issue 10314003: [OTS] Improve GYP build

Issue 10314003: [OTS] Improve GYP build (Closed)

Created:
8 years, 7 months ago by bashi

Modified:
8 years, 7 months ago

Reviewers:
Yusuke Sato, agl

CC:
chromium-reviews, agl

Base URL:
http://ots.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

[OTS] Improve GYP build - Added gyp_ots script which fetches gyp and creates build files. - Cleanup ots-standalone.gyp and added further test program targets. - Fixed some compile errors of test programs on Mac.

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -24 lines)			Patch
M	INSTALL	View		1 chunk	+26 lines, -14 lines	0 comments	Download
A	gyp_ots	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	ots-standalone.gyp	View	1	4 chunks	+76 lines, -4 lines	0 comments	Download
M	test/file-stream.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	test/idempotent.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	test/ot-sanitise.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/perf.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	test/validator-checker.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bashi

Hi Yusuke-san, Could you take a look? This CL doesn't change behavior; just for testing.

8 years, 7 months ago (2012-05-02 08:07:36 UTC) #1

agl

LGTM https://chromiumcodereview.appspot.com/10314003/diff/1/gyp_ots File gyp_ots (right): https://chromiumcodereview.appspot.com/10314003/diff/1/gyp_ots#newcode12 gyp_ots:12: _GYP_FETCH_URL = 'http://gyp.googlecode.com/svn/trunk@' + _GYP_REVISION Please make this ...

8 years, 7 months ago (2012-05-02 16:43:31 UTC) #2

bashi

8 years, 7 months ago (2012-05-07 08:41:59 UTC) #3

Thank you for review!

https://chromiumcodereview.appspot.com/10314003/diff/1/gyp_ots
File gyp_ots (right):

https://chromiumcodereview.appspot.com/10314003/diff/1/gyp_ots#newcode12
gyp_ots:12: _GYP_FETCH_URL = 'http://gyp.googlecode.com/svn/trunk@' +
_GYP_REVISION
On 2012/05/02 16:43:31, agl wrote:
> Please make this "https://"... so that we aren't downloading and running
> untrusted code.

Done.

https://chromiumcodereview.appspot.com/10314003/diff/1/gyp_ots#newcode17
gyp_ots:17: svn_process = subprocess.Popen(['svn', 'checkout', _GYP_FETCH_URL,
gyp_dir])
On 2012/05/02 16:43:31, agl wrote:
> I think subprocess.call is a neater way to do this, but not critical.

Done.

https://chromiumcodereview.appspot.com/10314003/diff/1/ots-standalone.gyp
File ots-standalone.gyp (right):

https://chromiumcodereview.appspot.com/10314003/diff/1/ots-standalone.gyp#new...
ots-standalone.gyp:27: '-g',
On 2012/05/02 16:43:31, agl wrote:
> Other flags are GCC specific, so why not -ggdb?

There is no strong reason. Reverted.

Expand Messages | Collapse Messages