Improve socket.write() to make sure all data will be sent out.

chrome/browser/extensions/api/socket/udp_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/socket/udp_socket.h"
 
 #include "chrome/browser/extensions/api/api_resource.h"
 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_errors.h"
@@ skipping 77 matching lines @@
     io_buffer = new net::IOBuffer(count);
     result = socket_.Read(io_buffer.get(), count,
         base::Bind(&UDPSocket::OnReadComplete, base::Unretained(this),
             io_buffer));
   } while (false);
 
   if (result != net::ERR_IO_PENDING)
     OnReadComplete(io_buffer, result);
 }
 
-void UDPSocket::Write(scoped_refptr<net::IOBuffer> io_buffer,
-                      int byte_count,
-                      const CompletionCallback& callback) {
-  DCHECK(!callback.is_null());
-
-  if (!write_callback_.is_null()) {
-    // TODO(penghuang): Put requests in a pending queue to support multiple
-    // write calls.
-    callback.Run(net::ERR_IO_PENDING);
-    return;
-  } else {
-    write_callback_ = callback;
-  }
-
-  int result = net::ERR_FAILED;
-  do {
-    if (!socket_.is_connected()) {
-      result = net::ERR_SOCKET_NOT_CONNECTED;
-      break;
-    }
-
-    result = socket_.Write(
-        io_buffer.get(), byte_count,
-        base::Bind(&UDPSocket::OnWriteComplete, base::Unretained(this)));
-  } while (false);
-
-  if (result != net::ERR_IO_PENDING)
-    OnWriteComplete(result);
+int UDPSocket::WriteImpl(net::IOBuffer* io_buffer,
+                         int io_buffer_size,
+                         const net::CompletionCallback& callback) {
+  if (!socket_.is_connected())
+    return net::ERR_SOCKET_NOT_CONNECTED;
+  else
+    return socket_.Write(io_buffer, io_buffer_size, callback);
 }
 
 void UDPSocket::RecvFrom(int count,
                          const RecvFromCompletionCallback& callback) {
   DCHECK(!callback.is_null());
 
   if (!recv_from_callback_.is_null()) {
     callback.Run(net::ERR_IO_PENDING, NULL, NULL, 0);
     return;
   } else {
@@ skipping 70 matching lines @@
     OnSendToComplete(result);
 }
 
 void UDPSocket::OnReadComplete(scoped_refptr<net::IOBuffer> io_buffer,
                                int result) {
   DCHECK(!read_callback_.is_null());
   read_callback_.Run(result, io_buffer);
   read_callback_.Reset();
 }
 
-void UDPSocket::OnWriteComplete(int result) {
-  DCHECK(!write_callback_.is_null());
-  write_callback_.Run(result);
-  write_callback_.Reset();
-}
-
 void UDPSocket::OnRecvFromComplete(scoped_refptr<net::IOBuffer> io_buffer,
                                    scoped_refptr<IPEndPoint> address,
                                    int result) {
   DCHECK(!recv_from_callback_.is_null());
   std::string ip;
   int port = 0;
   if (result > 0 && address.get()) {
     IPEndPointToStringAndPort(address->data, &ip, &port);
   }
   recv_from_callback_.Run(result, io_buffer, ip, port);
   recv_from_callback_.Reset();
 }
 
 void UDPSocket::OnSendToComplete(int result) {
   DCHECK(!send_to_callback_.is_null());
   send_to_callback_.Run(result);
   send_to_callback_.Reset();
 }
 
 }  // namespace extensions