Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 10310136: ui: Move NativeTheme files into ui/base/native_theme/ directory. (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, James Su
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : fix gyp files #

Patch Set 3 : fix wim #

Patch Set 4 : one more win fix #

Patch Set 5 : fix android #

Patch Set 6 : reland with alexei changes and fix DEPS #

Patch Set 7 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+696 lines, -5680 lines) Patch
M chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M ui/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A + ui/base/native_theme/native_theme.h View 4 chunks +10 lines, -8 lines 0 comments Download
A + ui/base/native_theme/native_theme.cc View 1 2 3 4 5 2 chunks +3 lines, -5 lines 0 comments Download
A + ui/base/native_theme/native_theme_android.h View 1 2 3 4 5 3 chunks +12 lines, -8 lines 0 comments Download
A + ui/base/native_theme/native_theme_android.cc View 1 2 3 4 5 3 chunks +18 lines, -20 lines 0 comments Download
A + ui/base/native_theme/native_theme_aura.h View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/base/native_theme/native_theme_aura.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + ui/base/native_theme/native_theme_base.h View 2 chunks +9 lines, -5 lines 0 comments Download
A + ui/base/native_theme/native_theme_base.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + ui/base/native_theme/native_theme_gtk.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + ui/base/native_theme/native_theme_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + ui/base/native_theme/native_theme_win.h View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
A + ui/base/native_theme/native_theme_win.cc View 1 2 3 6 9 chunks +17 lines, -17 lines 0 comments Download
A + ui/base/native_theme/native_theme_win_unittest.cc View 1 2 3 4 5 1 chunk +6 lines, -2 lines 0 comments Download
D ui/gfx/native_theme.h View 1 chunk +0 lines, -271 lines 0 comments Download
D ui/gfx/native_theme.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/native_theme_android.h View 1 chunk +0 lines, -172 lines 0 comments Download
D ui/gfx/native_theme_android.cc View 1 chunk +0 lines, -804 lines 0 comments Download
D ui/gfx/native_theme_aura.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/gfx/native_theme_aura.cc View 1 chunk +0 lines, -295 lines 0 comments Download
D ui/gfx/native_theme_base.h View 1 chunk +0 lines, -167 lines 0 comments Download
D ui/gfx/native_theme_base.cc View 1 chunk +0 lines, -973 lines 0 comments Download
D ui/gfx/native_theme_gtk.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/gfx/native_theme_gtk.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D ui/gfx/native_theme_win.h View 1 chunk +0 lines, -331 lines 0 comments Download
D ui/gfx/native_theme_win.cc View 1 chunk +0 lines, -1779 lines 0 comments Download
D ui/gfx/native_theme_win_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 chunks +22 lines, -22 lines 0 comments Download
M ui/ui_unittests.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/checkbox.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 2 3 4 5 3 chunks +15 lines, -18 lines 0 comments Download
M ui/views/controls/button/radio_button.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/radio_button.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/text_button.h View 3 chunks +10 lines, -10 lines 0 comments Download
M ui/views/controls/button/text_button.cc View 8 chunks +40 lines, -40 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_win.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/focusable_border.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/label.cc View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/menu/menu_config_views.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_config_win.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_item_view_views.cc View 1 2 3 4 5 3 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_item_view_win.cc View 1 2 3 4 5 3 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_separator_views.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_separator_win.cc View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_views.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_views.cc View 1 2 3 4 5 11 chunks +53 lines, -53 lines 0 comments Download
M ui/views/controls/tabbed_pane/native_tabbed_pane_win.cc View 1 2 3 4 5 3 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/table/table_view_views.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/tree/tree_view_views.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/examples/native_theme_button_example.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/views/examples/native_theme_button_example.cc View 1 2 3 4 5 5 chunks +29 lines, -29 lines 0 comments Download
M ui/views/examples/native_theme_checkbox_example.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/native_theme_delegate.h View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
M ui/views/native_theme_painter.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 2 3 4 5 4 chunks +11 lines, -12 lines 0 comments Download
M webkit/glue/webthemeengine_impl_android.cc View 5 chunks +32 lines, -32 lines 0 comments Download
M webkit/glue/webthemeengine_impl_linux.cc View 1 2 3 4 5 5 chunks +32 lines, -32 lines 0 comments Download
M webkit/glue/webthemeengine_impl_win.cc View 1 2 3 4 5 22 chunks +218 lines, -218 lines 0 comments Download
M webkit/tools/test_shell/test_shell_platform_delegate_win.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
8 years, 7 months ago (2012-05-12 23:33:41 UTC) #1
tfarina
fix gyp files
8 years, 7 months ago (2012-05-12 23:44:26 UTC) #2
tfarina
fix wim
8 years, 7 months ago (2012-05-12 23:57:34 UTC) #3
tfarina
one more win fix
8 years, 7 months ago (2012-05-13 00:06:19 UTC) #4
tfarina
fix android
8 years, 7 months ago (2012-05-13 14:06:43 UTC) #5
tfarina
ping?
8 years, 7 months ago (2012-05-14 20:07:51 UTC) #6
Ben Goodger (Google)
8 years, 7 months ago (2012-05-14 22:00:42 UTC) #7
rubber stamp lgtm.

Powered by Google App Engine
This is Rietveld 408576698