Support placeholder text in NativeTextfieldViews.

Support placeholder text in NativeTextfieldViews.

- Rename text_to_display_when_empty -> placehodler_text;
- Draw placeholder text when there is no user text;

BUG=none.
TEST=none.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137529

[tfarina, 2012-05-14 18:54:12]

https://chromiumcodereview.appspot.com/10310131/diff/2001/ui/views/controls/t...
File ui/views/controls/textfield/textfield.h (right):

https://chromiumcodereview.appspot.com/10310131/diff/2001/ui/views/controls/t...
ui/views/controls/textfield/textfield.h:165: const string16& placeholder_text()
{
nit: I think this function should be const too. Not just the return type.

[sky, 2012-05-14 20:58:45]

LGTM, but wait for Mike or Oshima to sign off on NativeTextfieldViews.

[oshima, 2012-05-14 21:07:24]

https://chromiumcodereview.appspot.com/10310131/diff/2001/ui/views/controls/t...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://chromiumcodereview.appspot.com/10310131/diff/2001/ui/views/controls/t...
ui/views/controls/textfield/native_textfield_views.cc:842:
GetRenderText()->display_rect());
does this work with RTL text?

[xiyuan, 2012-05-14 21:13:30]

https://chromiumcodereview.appspot.com/10310131/diff/2001/ui/views/controls/t...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://chromiumcodereview.appspot.com/10310131/diff/2001/ui/views/controls/t...
ui/views/controls/textfield/native_textfield_views.cc:842:
GetRenderText()->display_rect());
On 2012/05/14 21:07:24, oshima wrote:
> does this work with RTL text?

Think it should. 

The code paints the placehold text when user has not input anything into the
Textfield. That is, the field is empty and it's not attempting to paint some
text concatenated with another string.

Do we need to do anything special for RTL? Thought canvas->DrawStringInt handles
that.

[oshima, 2012-05-14 22:05:35]

https://chromiumcodereview.appspot.com/10310131/diff/2001/ui/views/controls/t...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://chromiumcodereview.appspot.com/10310131/diff/2001/ui/views/controls/t...
ui/views/controls/textfield/native_textfield_views.cc:842:
GetRenderText()->display_rect());
On 2012/05/14 21:13:30, xiyuan wrote:
> On 2012/05/14 21:07:24, oshima wrote:
> > does this work with RTL text?
> 
> Think it should. 
> 
> The code paints the placehold text when user has not input anything into the
> Textfield. That is, the field is empty and it's not attempting to paint some
> text concatenated with another string.
> 
> Do we need to do anything special for RTL? Thought canvas->DrawStringInt
handles
> that. 

It does, but DrawStringInt and RenderText handle the text direction slightly
different way,
and I wanted to make sure there is no issue. I'm guessing that if the
placeholder text is LTR, it will print it in LTR, but i thing this isn't really
issue because it must have the correct text. LGTM

[commit-bot: I haz the power, 2012-05-14 23:33:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10310131/3008

[commit-bot: I haz the power, 2012-05-15 00:48:56]

Try job failure for 10310131-3008 (retry) (previous was lost) on linux_rel for
steps "base_unittests, browser_tests, net_unittests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[msw, 2012-05-15 02:29:22]

https://chromiumcodereview.appspot.com/10310131/diff/3008/ui/views/controls/t...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://chromiumcodereview.appspot.com/10310131/diff/3008/ui/views/controls/t...
ui/views/controls/textfield/native_textfield_views.cc:836: if
(model_->GetText().empty() &&
Should placeholder text disappear on textfield focus?

https://chromiumcodereview.appspot.com/10310131/diff/3008/ui/views/controls/t...
File ui/views/controls/textfield/textfield.cc (right):

https://chromiumcodereview.appspot.com/10310131/diff/3008/ui/views/controls/t...
ui/views/controls/textfield/textfield.cc:33: const SkColor
kDefaultPlaceholderTextColor = SK_ColorLTGRAY;
This should probably go in an anonymous namespace.

[xiyuan, 2012-05-15 16:20:04]

http://codereview.chromium.org/10310131/diff/3008/ui/views/controls/textfield...
File ui/views/controls/textfield/native_textfield_views.cc (right):

http://codereview.chromium.org/10310131/diff/3008/ui/views/controls/textfield...
ui/views/controls/textfield/native_textfield_views.cc:836: if
(model_->GetText().empty() &&
On 2012/05/15 02:29:22, msw wrote:
> Should placeholder text disappear on textfield focus?

I prefer to show placeholder even if the textfield is focused. This is inline
with the current webkit behavior and useful when there is only a focusable
textfield in the UI, like in new applist bubble.

http://codereview.chromium.org/10310131/diff/3008/ui/views/controls/textfield...
File ui/views/controls/textfield/textfield.cc (right):

http://codereview.chromium.org/10310131/diff/3008/ui/views/controls/textfield...
ui/views/controls/textfield/textfield.cc:33: const SkColor
kDefaultPlaceholderTextColor = SK_ColorLTGRAY;
On 2012/05/15 02:29:22, msw wrote:
> This should probably go in an anonymous namespace.

Done. Was not careful enough to notice this. :p

[msw, 2012-05-17 19:58:04]

LGTM