chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc - Issue 10310124: Implement a ResourceThrottle for URL overriding in Chrome on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc

Issue 10310124: Implement a ResourceThrottle for URL overriding in Chrome on Android. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: incorporated feedback Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc ('k') | chrome/browser/extensions/extension_protocols_unittest.cc » ('j') | net/url_request/url_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc

index 02c75ec105fcdb14c32c089c210221e9d860d3de..363cc61d43238cb6edcd364312cee9fb9ba2ed5c 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc

@@ -70,12 +70,12 @@ TEST(WebRequestConditionTest, CreateCondition) {

TestURLRequest match_request(GURL("http://www.example.com"), NULL);

content::ResourceRequestInfo::AllocateForTesting(&match_request,

- ResourceType::MAIN_FRAME, NULL);

+ ResourceType::MAIN_FRAME, NULL, -1, -1);

EXPECT_TRUE(result->IsFulfilled(&match_request, ON_BEFORE_REQUEST));

TestURLRequest wrong_resource_type(GURL("https://www.example.com"), NULL);

content::ResourceRequestInfo::AllocateForTesting(&wrong_resource_type,

- ResourceType::SUB_FRAME, NULL);

+ ResourceType::SUB_FRAME, NULL, -1, -1);

EXPECT_FALSE(result->IsFulfilled(&wrong_resource_type, ON_BEFORE_REQUEST));

}