Fix ucontext structure for Android on x86

Fix ucontext structure for Android on x86

[Lijuan Xiao, 2012-05-11 07:08:08]

Hi, when I run d8 compiled for Android on x86 with "--prof", it will crash. I
made a fix here. Would you please help review? Many thanks.

[benm (inactive), 2012-05-11 14:00:48]

Thanks for the patch! I was able to reproduce the crash and this seems to fix
it. I am curious though where these definitions have come from?

http://codereview.chromium.org/10310116/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

http://codereview.chromium.org/10310116/diff/1/src/platform-linux.cc#newcode969
src/platform-linux.cc:969: struct sigcontext {
Where have these definitions come from?

http://codereview.chromium.org/10310116/diff/1/src/platform-linux.cc#newcode970
src/platform-linux.cc:970: uint32_t gregs[16];
Please remove the whitespace from the end of each line.

[Lijuan Xiao, 2012-05-14 03:51:09]

Hi, Ben, thanks for your review. The definition is from sigcontext definition in
Android bionic for x86. I made some modifications to make it concise enough for
v8 usage (basically v8 just need EBP/ESP/EIP). I uploaded a new version with 1)
length of general-purpose register array from 16->19 (I made a mistake in
counting); 2) removing the extra whitespaces.Would you please have a look?
-Lijuan

[ulan, 2012-05-14 11:51:48]

LGTM, thank you for patch!

Could you please sign the Google Individual Contributor License Agreement?

It is possible to sign electronically, see
http://code.google.com/p/v8/wiki/Contributing

After that I can land it for you.

[Lijuan Xiao, 2012-05-15 08:48:47]

Hi, I should have applied CCLA. I am contributing on behalf of Intel corporation
as Lijuan Xiao (lijuan.xiao@intel.com). Please help me to land the patch. Many
thanks~ -Lijuan

[ulan, 2012-05-15 09:20:49]

Thanks, you are indeed in the CCLA list. Landed the patch.

On 2012/05/15 08:48:47, Lijuan Xiao wrote:
> Hi, I should have applied CCLA. I am contributing on behalf of Intel
corporation
> as Lijuan Xiao (mailto:lijuan.xiao@intel.com). Please help me to land the
patch. Many
> thanks~ -Lijuan