Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 10310098: Don't make try_compile_test bot RED if native tests fail to compile. (Closed)

Created:
8 years, 7 months ago by nilesh
Modified:
8 years, 7 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Fix chromium_base.jar path for APK builds. Also, Don't make try_compile_test bot RED if native tests APK fails to compile. BUG=125059 TBR=mark@chromium.org,tsepez@chromium.org TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136496

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fix patch for replaceme-debug.apk #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M base/base.gyp View 1 2 chunks +2 lines, -2 lines 1 comment Download
M build/android/buildbot_functions.sh View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ui_unittests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nilesh
8 years, 7 months ago (2012-05-10 21:28:02 UTC) #1
Yaron
http://codereview.chromium.org/10310098/diff/4001/build/android/buildbot_functions.sh File build/android/buildbot_functions.sh (right): http://codereview.chromium.org/10310098/diff/4001/build/android/buildbot_functions.sh#newcode210 build/android/buildbot_functions.sh:210: echo "@@@STEP_WARNINGS@@@" I dunno. It seems like native apk ...
8 years, 7 months ago (2012-05-10 22:13:48 UTC) #2
Yaron
lgtm given that it'll still fail on test compile but warn on test failure
8 years, 7 months ago (2012-05-10 22:35:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10310098/3
8 years, 7 months ago (2012-05-10 23:28:53 UTC) #4
commit-bot: I haz the power
Presubmit check for 10310098-3 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-10 23:28:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10310098/3
8 years, 7 months ago (2012-05-10 23:33:20 UTC) #6
commit-bot: I haz the power
Try job failure for 10310098-3 (retry) (retry) on android for steps "Compile, build". It's a ...
8 years, 7 months ago (2012-05-10 23:46:08 UTC) #7
John Grabowski
LGTM http://codereview.chromium.org/10310098/diff/3/base/base.gyp File base/base.gyp (right): http://codereview.chromium.org/10310098/diff/3/base/base.gyp#newcode672 base/base.gyp:672: '<(PRODUCT_DIR)/lib.java/chromium_base.jar' Sorry... this was my fault. It was ...
8 years, 7 months ago (2012-05-10 23:58:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10310098/3
8 years, 7 months ago (2012-05-11 01:33:16 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 03:23:53 UTC) #10
Change committed as 136496

Powered by Google App Engine
This is Rietveld 408576698