Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 10310089: Make me2me_host a Mac bundle (Closed)

Created:
8 years, 7 months ago by Lambros
Modified:
8 years, 7 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Make me2me_host a Mac bundle This is a prerequisite for showing the Disconnect window in Mac Me2Me host. BUG=127322 TEST=manual: install/run/uninstall Me2Me Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M remoting/host/installer/mac/ChromotingHostService.packproj View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.me2me.sh View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/installer/mac/do_signing.sh View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/installer/mac/uninstaller/remoting_uninstaller.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/remoting_me2me_host-Info.plist View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 3 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lambros
8 years, 7 months ago (2012-05-10 00:54:24 UTC) #1
garykac
LGTM
8 years, 7 months ago (2012-05-10 01:18:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10310089/1
8 years, 7 months ago (2012-05-10 17:03:46 UTC) #3
commit-bot: I haz the power
Try job failure for 10310089-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-10 17:52:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10310089/1
8 years, 7 months ago (2012-05-10 19:42:42 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 21:26:22 UTC) #6
Change committed as 136393

Powered by Google App Engine
This is Rietveld 408576698