Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10310084: Checkout Web Page Replay in src/third_party (was chrome/tools/build/third_party). (Closed)

Created:
8 years, 7 months ago by slamm_google
Modified:
8 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, tonyg
Visibility:
Public.

Description

Checkout Web Page Replay in src/third_party (was chrome/tools/build/third_party). Previously (issue 10020064), this was committed and backed out because of licensecheck.pl issues. This CL depends on issue 10310044 to fix licensecheck.pl UNKNOWNs for webpagereplay/third_party/dns. This CL differs from 10020064 in that it grabs an updated Web Page Replay to fix UNKNOWNs for webpagereplay/third_party/nbhttp. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/python/google/webpagereplay_utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
slamm_google
Web Page Replay is ready to get added (this CL) once licensecheck.pl gets updated: https://chromiumcodereview.appspot.com/10310044/ ...
8 years, 7 months ago (2012-05-10 17:33:54 UTC) #1
tonyg
BTW, I think we'll also have to do this: http://code.google.com/p/chromium/wiki/UsingNewGit#Adding_new_repositories_to_DEPS
8 years, 7 months ago (2012-05-10 17:42:11 UTC) #2
slamm_google
Where are all the places I should expect to see the source? I filed an ...
8 years, 7 months ago (2012-05-10 18:14:52 UTC) #3
cmp
Yeah, I think you're set here thanks to filing crbug.com/124073.
8 years, 7 months ago (2012-05-10 19:05:17 UTC) #4
cmp
lgtm
8 years, 7 months ago (2012-05-10 19:05:26 UTC) #5
slamm_google
On 2012/05/10 19:05:26, cmp wrote: > lgtm This should be good to get committed (I ...
8 years, 7 months ago (2012-05-11 19:48:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/slamm@google.com/10310084/1
8 years, 7 months ago (2012-05-11 20:02:55 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 23:32:19 UTC) #8
Change committed as 136708

Powered by Google App Engine
This is Rietveld 408576698