Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 10310071: [RFC] Support CWS intents query URL (Closed)

Created:
8 years, 7 months ago by groby-ooo-7-16
Modified:
8 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Support CWS intents query URL BUG=none TEST=ExtensionConstantsTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136233

Patch Set 1 #

Patch Set 2 : Added unit tests #

Patch Set 3 : Merge to HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
A chrome/common/extensions/extension_constants_unittest.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
groby-ooo-7-16
This is WIP - just wanted some feedback before I continue 1) It seems extension_constants ...
8 years, 7 months ago (2012-05-09 01:29:25 UTC) #1
Aaron Boodman
I don't have a super strong opinion here. Seems fine here. LGTM
8 years, 7 months ago (2012-05-09 19:05:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10310071/2002
8 years, 7 months ago (2012-05-09 23:55:47 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 7 months ago (2012-05-10 02:09:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10310071/2002
8 years, 7 months ago (2012-05-10 02:27:15 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 02:37:22 UTC) #6
Try job failure for 10310071-2002 (retry) on android for steps "Compile, build".
It's a second try, previously, steps "Compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Powered by Google App Engine
This is Rietveld 408576698