Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/common/extensions/extension.h

Issue 10310069: There is stability regression between 1104 and 1105.0 build. Looking at changelogs, this change loo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/extension_sync_data.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
7 #pragma once 7 #pragma once
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <map> 10 #include <map>
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 536
537 // Accessors: 537 // Accessors:
538 538
539 const FilePath& path() const { return path_; } 539 const FilePath& path() const { return path_; }
540 const GURL& url() const { return extension_url_; } 540 const GURL& url() const { return extension_url_; }
541 Location location() const; 541 Location location() const;
542 const std::string& id() const; 542 const std::string& id() const;
543 const Version* version() const { return version_.get(); } 543 const Version* version() const { return version_.get(); }
544 const std::string VersionString() const; 544 const std::string VersionString() const;
545 const std::string& name() const { return name_; } 545 const std::string& name() const { return name_; }
546 const std::string& non_localized_name() const { return non_localized_name_; }
547 const std::string public_key() const { return public_key_; } 546 const std::string public_key() const { return public_key_; }
548 const std::string& description() const { return description_; } 547 const std::string& description() const { return description_; }
549 int manifest_version() const { return manifest_version_; } 548 int manifest_version() const { return manifest_version_; }
550 bool converted_from_user_script() const { 549 bool converted_from_user_script() const {
551 return converted_from_user_script_; 550 return converted_from_user_script_;
552 } 551 }
553 const UserScriptList& content_scripts() const { return content_scripts_; } 552 const UserScriptList& content_scripts() const { return content_scripts_; }
554 ExtensionAction* page_action() const { return page_action_.get(); } 553 ExtensionAction* page_action() const { return page_action_.get(); }
555 ExtensionAction* browser_action() const { return browser_action_.get(); } 554 ExtensionAction* browser_action() const { return browser_action_.get(); }
556 ExtensionAction::Type declared_action_type() const { 555 ExtensionAction::Type declared_action_type() const {
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
849 // Cached images for this extension. This should only be touched on the UI 848 // Cached images for this extension. This should only be touched on the UI
850 // thread. 849 // thread.
851 mutable ImageCache image_cache_; 850 mutable ImageCache image_cache_;
852 851
853 // The extension's human-readable name. Name is used for display purpose. It 852 // The extension's human-readable name. Name is used for display purpose. It
854 // might be wrapped with unicode bidi control characters so that it is 853 // might be wrapped with unicode bidi control characters so that it is
855 // displayed correctly in RTL context. 854 // displayed correctly in RTL context.
856 // NOTE: Name is UTF-8 and may contain non-ascii characters. 855 // NOTE: Name is UTF-8 and may contain non-ascii characters.
857 std::string name_; 856 std::string name_;
858 857
859 // A non-localized version of the extension's name. This is useful for
860 // debug output.
861 std::string non_localized_name_;
862
863 // The version of this extension's manifest. We increase the manifest 858 // The version of this extension's manifest. We increase the manifest
864 // version when making breaking changes to the extension system. 859 // version when making breaking changes to the extension system.
865 // Version 1 was the first manifest version (implied by a lack of a 860 // Version 1 was the first manifest version (implied by a lack of a
866 // manifest_version attribute in the extension's manifest). We initialize 861 // manifest_version attribute in the extension's manifest). We initialize
867 // this member variable to 0 to distinguish the "uninitialized" case from 862 // this member variable to 0 to distinguish the "uninitialized" case from
868 // the case when we know the manifest version actually is 1. 863 // the case when we know the manifest version actually is 1.
869 int manifest_version_; 864 int manifest_version_;
870 865
871 // The absolute path to the directory the extension is stored in. 866 // The absolute path to the directory the extension is stored in.
872 FilePath path_; 867 FilePath path_;
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
1113 // only contain the removed permissions. 1108 // only contain the removed permissions.
1114 const ExtensionPermissionSet* permissions; 1109 const ExtensionPermissionSet* permissions;
1115 1110
1116 UpdatedExtensionPermissionsInfo( 1111 UpdatedExtensionPermissionsInfo(
1117 const Extension* extension, 1112 const Extension* extension,
1118 const ExtensionPermissionSet* permissions, 1113 const ExtensionPermissionSet* permissions,
1119 Reason reason); 1114 Reason reason);
1120 }; 1115 };
1121 1116
1122 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 1117 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_sync_data.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698