ninja: Add '/', '\', and '.' to the set of shell-safe characters.

ninja: Add '/', '\', and '.' to the set of shell-safe characters.

With this, -I flags no longer get escaped. This is mostly OCD, but
a back-of-the-envelope calculation says that this might make empty
builds faster by 20ms or so.
Committed: https://code.google.com/p/gyp/source/detail?r=1368

[scottmg, 2012-05-08 21:14:31]

On 2012/05/08 21:09:42, Nico wrote:

I don't think the re matches the comment. I think the \ escapes the /.

[Mark Mentovai, 2012-05-08 21:14:40]

Can you use EncodePOSIXShellArgument from common.py? Or a twist on it?

[scottmg, 2012-05-08 21:16:11]

On 2012/05/08 21:14:31, scottmg wrote:
> On 2012/05/08 21:09:42, Nico wrote:
> 
> I don't think the re matches the comment. I think the \ escapes the /.

>>> import re
>>> re.match(r'[.\/-]', '\\')
>>> re.match(r'[.\/-]', '/')
<_sre.SRE_Match object at 0x01E74DB0>

Or maybe that's the intention so that \ gets escaped on posix?

[Mark Mentovai, 2012-05-08 21:20:27]

In a Python “r” (raw) string, \ doesn’t escape diddly squat.

[scottmg, 2012-05-08 21:22:04]

On 2012/05/08 21:20:27, Mark Mentovai wrote:
> In a Python “r” (raw) string, \ doesn’t escape diddly squat.

it's not a string escape, it's a re character class escape.

[Nico, 2012-05-08 21:29:40]

On 2012/05/08 21:14:31, scottmg wrote:
> On 2012/05/08 21:09:42, Nico wrote:
> 
> I don't think the re matches the comment. I think the \ escapes the /.

Serves me right for trying to do something windows while not at a windows box
:-) Done.


(
>>> re.findall(r'[/]', 'asd/asdf')
['/']
>>> re.findall(r'[\/]', 'asd/asdf')
['/']
>>> re.findall(r'[\/]', 'asd\/asdf')
['/']
>>> re.findall(r'[\/]', r'asd\/asdf')
['/']
>>> re.findall(r'[\/]', r'asd\asdf')
[]
>>> re.findall(r'[\\/]', r'asd\asdf')
['\\']
)

[Nico, 2012-05-08 21:31:29]

On 2012/05/08 21:14:40, Mark Mentovai wrote:
> Can you use EncodePOSIXShellArgument from common.py? Or a twist on it?

This function tries to escape things for cmd.exe too I believe.

[scottmg, 2012-05-08 21:31:35]

lgtm