Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 10310053: Support Ninja being invoked from MinGW shells (Closed)

Created:
8 years, 7 months ago by Ryan Sleevi
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Support Ninja being invoked from MinGW shells BUG=none TEST=it works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ninja View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Sleevi
scottmg: FYI nsylvain: OWNERS
8 years, 7 months ago (2012-05-08 00:41:07 UTC) #1
scottmg
On 2012/05/08 00:41:07, Ryan Sleevi wrote: > scottmg: FYI > nsylvain: OWNERS Cool, is that ...
8 years, 7 months ago (2012-05-08 00:57:12 UTC) #2
Ryan Sleevi
On 2012/05/08 00:57:12, scottmg wrote: > On 2012/05/08 00:41:07, Ryan Sleevi wrote: > > scottmg: ...
8 years, 7 months ago (2012-05-08 01:02:09 UTC) #3
nsylvain
LGTM from owner
8 years, 7 months ago (2012-05-08 15:38:17 UTC) #4
nsylvain
LGTM from owner
8 years, 7 months ago (2012-05-08 15:38:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10310053/1
8 years, 7 months ago (2012-05-08 17:59:45 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-08 18:07:53 UTC) #7
Change committed as 135873

Powered by Google App Engine
This is Rietveld 408576698