Issue 10310049: Disable one-click-signin for all platforms for M20. This CL will be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10310049: Disable one-click-signin for all platforms for M20. This CL will be (Closed)

Created:
8 years, 7 months ago by Roger Tawa OOO till Jul 10th

Modified:
8 years, 7 months ago

Reviewers:
tim (not reviewing), dharani1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Disable one-click-signin for all platforms for M20. This CL will be merged to M20 and then reverted on trunk for M21. BUG=126522 TEST=Make sure one-click sign is not visible on all platforms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135749

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	build/common.gypi	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 5 (0 generated)

tim (not reviewing)

LGTM. Adding dharani (tpm for 20) as FYI, since this feature (which has been baking ...

8 years, 7 months ago (2012-05-07 19:57:00 UTC) #2

dharani

Thanks for letting me know! Is there a bug for external dependency? If so please ...

8 years, 7 months ago (2012-05-07 20:01:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10310049/1

8 years, 7 months ago (2012-05-07 20:08:06 UTC) #4

Change committed as 135749