lib/compiler/implementation/emitter.dart - Issue 10310040: Sort the output (for now just the classes and instance members).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/emitter.dart

Issue 10310040: Sort the output (for now just the classes and instance members). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add test. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/elements/elements.dart ('k') | lib/compiler/implementation/scanner/class_element_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/emitter.dart

diff --git a/lib/compiler/implementation/emitter.dart b/lib/compiler/implementation/emitter.dart

index dda702ae1b39e367d535a9e8d545d9378d995eb1..0b6b4ea5ac3c01c8f09fc0ea052501b6ee219005 100644

--- a/lib/compiler/implementation/emitter.dart

+++ b/lib/compiler/implementation/emitter.dart

@@ -487,7 +487,15 @@ function() {

neededClasses.add(superclass);

}

- for (ClassElement element in neededClasses) {

+ List<ClassElement> sortedClasses =

+ new List<ClassElement>.from(neededClasses);

+ sortedClasses.sort((ClassElement class1, ClassElement class2) {

+ // We sort by the ids of the classes. There is no guarantee that these

+ // ids are meaningful (or even deterministic), but in the current

+ // implementation they are increasing within a source file.

+ return class1.id - class2.id;

+ });

+ for (ClassElement element in sortedClasses) {

generateClass(element, buffer);

}