Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10310037: Fix regression on constant folding an interceptor into a dynamic invocation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | tests/language/getter_setter_interceptor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/optimize.dart
===================================================================
--- lib/compiler/implementation/ssa/optimize.dart (revision 7375)
+++ lib/compiler/implementation/ssa/optimize.dart (working copy)
@@ -185,7 +185,7 @@
return node.inputs[1];
}
- if (!input.canBePrimitive() && !node.getter) {
+ if (!input.canBePrimitive() && !node.getter && !node.setter) {
return fromInterceptorToDynamicInvocation(node, node.name);
}
@@ -586,8 +586,8 @@
HInvokeInterceptor length = new HInvokeInterceptor(
Selector.INVOCATION_0,
const SourceString("length"),
- true,
- <HInstruction>[interceptor, receiver]);
+ <HInstruction>[interceptor, receiver],
+ getter: true);
length.propagatedType = HType.INTEGER;
node.block.addBefore(node, length);
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | tests/language/getter_setter_interceptor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698