lib/compiler/implementation/ssa/optimize.dart - Issue 10310037: Fix regression on constant folding an interceptor into a dynamic invocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10310037: Fix regression on constant folding an interceptor into a dynamic invocation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/ssa/nodes.dart ('K') | « lib/compiler/implementation/ssa/nodes.dart ('k') | tests/language/getter_setter_interceptor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/ssa/optimize.dart

===================================================================

--- lib/compiler/implementation/ssa/optimize.dart (revision 7375)

+++ lib/compiler/implementation/ssa/optimize.dart (working copy)

@@ -185,7 +185,7 @@

return node.inputs[1];

}

- if (!input.canBePrimitive() && !node.getter) {

+ if (!input.canBePrimitive() && !node.getter && !node.setter) {

return fromInterceptorToDynamicInvocation(node, node.name);

}

« lib/compiler/implementation/ssa/nodes.dart ('K') | « lib/compiler/implementation/ssa/nodes.dart ('k') | tests/language/getter_setter_interceptor_test.dart » ('j') | no next file with comments »