Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10310037: Fix regression on constant folding an interceptor into a dynamic invocation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/builder.dart
===================================================================
--- lib/compiler/implementation/ssa/builder.dart (revision 7375)
+++ lib/compiler/implementation/ssa/builder.dart (working copy)
@@ -1757,7 +1757,7 @@
HStatic target = new HStatic(staticInterceptor);
add(target);
List<HInstruction> inputs = <HInstruction>[target, receiver];
- push(new HInvokeInterceptor(selector, getterName, true, inputs));
+ push(new HInvokeInterceptor(selector, getterName, true, false, inputs));
} else {
push(new HInvokeDynamicGetter(selector, null, getterName, receiver));
}
@@ -1801,7 +1801,8 @@
HStatic target = new HStatic(staticInterceptor);
add(target);
List<HInstruction> inputs = <HInstruction>[target, receiver, value];
- add(new HInvokeInterceptor(selector, dartSetterName, false, inputs));
+ add(new HInvokeInterceptor(
+ selector, dartSetterName, false, true, inputs));
} else {
add(new HInvokeDynamicSetter(selector, null, dartSetterName,
receiver, value));
@@ -2008,7 +2009,8 @@
visit(node.receiver);
inputs.add(pop());
addGenericSendArgumentsToList(node.arguments, inputs);
- push(new HInvokeInterceptor(selector, dartMethodName, false, inputs));
+ push(new HInvokeInterceptor(
+ selector, dartMethodName, false, false, inputs));
return;
}
@@ -2753,7 +2755,8 @@
add(target);
visit(node.expression);
List<HInstruction> inputs = <HInstruction>[target, pop()];
- iterator = new HInvokeInterceptor(selector, iteratorName, false, inputs);
+ iterator = new HInvokeInterceptor(
+ selector, iteratorName, false, false, inputs);
add(iterator);
}
HInstruction buildCondition() {
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/nodes.dart » ('j') | lib/compiler/implementation/ssa/nodes.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698