Chromium Code Reviews
Help | Chromium Project | Sign in
(138)

Issue 10310034: Implement proper svn copy when a file is copied, moved or renamed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by M-A Ruel
Modified:
1 year, 11 months ago
CC:
chromium-reviews_chromium.org, Dirk Pranke, darin, Ben Goodger (Google)
Visibility:
Public.

Description

Implement proper svn copy when a file is copied, moved or renamed

R=nsylvain@chromium.org
BUG=
TEST=A basic unit test verifies history is kept

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135651

Patch Set 1 #

Patch Set 2 : Fix error in svn add #

Patch Set 3 : Now with unit tests #

Patch Set 4 : remove git unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Lint Patch
M checkout.py View 1 2 chunks +9 lines, -3 lines 0 comments ? errors Download
M tests/checkout_test.py View 1 2 3 1 chunk +30 lines, -1 line 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 8
M-A Ruel
1 year, 11 months ago #1
nsylvain
Since you use copy instead of move, will this remove the original? LGTM if so.
1 year, 11 months ago #2
M-A Ruel
On 2012/05/07 15:43:09, nsylvain wrote: > Since you use copy instead of move, will this ...
1 year, 11 months ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10310034/3001
1 year, 11 months ago #4
I haz the power (commit-bot)
Presubmit check for 10310034-3001 failed and returned exit status 1. warning: code.google.com certificate with fingerprint ...
1 year, 11 months ago #5
M-A Ruel
On 2012/05/07 15:55:53, I haz the power (commit-bot) wrote: > Traceback (most recent call last): ...
1 year, 11 months ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10310034/8001
1 year, 11 months ago #7
I haz the power (commit-bot)
1 year, 11 months ago #8
Change committed as 135651
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6