Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 10310034: Implement proper svn copy when a file is copied, moved or renamed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by M-A Ruel
Modified:
2 years, 10 months ago
CC:
chromium-reviews, Dirk Pranke, darin (slow to review), Ben Goodger (Google)
Visibility:
Public.

Description

Implement proper svn copy when a file is copied, moved or renamed R=nsylvain@chromium.org BUG= TEST=A basic unit test verifies history is kept Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135651

Patch Set 1 #

Patch Set 2 : Fix error in svn add #

Patch Set 3 : Now with unit tests #

Patch Set 4 : remove git unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M checkout.py View 1 2 chunks +9 lines, -3 lines 0 comments Download
M tests/checkout_test.py View 1 2 3 1 chunk +30 lines, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 8 (0 generated)
M-A Ruel
2 years, 10 months ago (2012-05-07 12:59:50 UTC) #1
nsylvain
Since you use copy instead of move, will this remove the original? LGTM if so.
2 years, 10 months ago (2012-05-07 15:43:09 UTC) #2
M-A Ruel
On 2012/05/07 15:43:09, nsylvain wrote: > Since you use copy instead of move, will this ...
2 years, 10 months ago (2012-05-07 15:47:15 UTC) #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10310034/3001
2 years, 10 months ago (2012-05-07 15:47:27 UTC) #4
I haz the power (commit-bot)
Presubmit check for 10310034-3001 failed and returned exit status 1. warning: code.google.com certificate with fingerprint ...
2 years, 10 months ago (2012-05-07 15:55:53 UTC) #5
M-A Ruel
On 2012/05/07 15:55:53, I haz the power (commit-bot) wrote: > Traceback (most recent call last): ...
2 years, 10 months ago (2012-05-07 16:05:14 UTC) #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10310034/8001
2 years, 10 months ago (2012-05-07 16:09:38 UTC) #7
I haz the power (commit-bot)
2 years, 10 months ago (2012-05-07 16:17:23 UTC) #8
Change committed as 135651
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted