Implement proper svn copy when a file is copied, moved or renamed

Implement proper svn copy when a file is copied, moved or renamed

R=nsylvain@chromium.org
BUG=
TEST=A basic unit test verifies history is kept

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135651

[nsylvain, 2012-05-07 15:43:09]

Since you use copy instead of move, will this remove the original?

LGTM if so.

[M-A Ruel, 2012-05-07 15:47:15]

On 2012/05/07 15:43:09, nsylvain wrote:
> Since you use copy instead of move, will this remove the original?
> 
> LGTM if so.

A file move is copy + delete. I have normalized that a while ago from upload.py
on both git and svn. A file rename is exactly the same as a file move.

[commit-bot: I haz the power, 2012-05-07 15:47:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10310034/3001

[commit-bot: I haz the power, 2012-05-07 15:55:53]

Presubmit check for 10310034-3001 failed and returned exit status 1.

warning: code.google.com certificate with fingerprint
51:f2:5b:a9:c0:af:c8:81:9f:48:23:43:c8:7f:49:00:5f:28:ee:d5 not verified (check
hostfingerprints or web.cacerts config setting)
Running presubmit commit checks ...
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit ERRORS **
tests/checkout_test.py failed!
Command tests/checkout_test.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
...F......................
======================================================================
FAIL: testMove (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 511, in testMove
    self.assertEquals(expected, out)
AssertionError: "# On branch working_branch\n# Your branch is ahead of
'origin/trunk' by 1 commit.\n#\nnothing to commit (working directory clean)\n"
!= '# On branch working_branch\nnothing to commit (working directory clean)\n'

----------------------------------------------------------------------
Ran 26 tests in 86.819s

FAILED (failures=1)


Presubmit checks took 495.8s to calculate.

[M-A Ruel, 2012-05-07 16:05:14]

On 2012/05/07 15:55:53, I haz the power (commit-bot) wrote:
> Traceback (most recent call last):
>   File "tests/checkout_test.py", line 511, in testMove
>     self.assertEquals(expected, out)
> AssertionError: "# On branch working_branch\n# Your branch is ahead of
> 'origin/trunk' by 1 commit.\n#\nnothing to commit (working directory clean)\n"
> != '# On branch working_branch\nnothing to commit (working directory clean)\n'

I run 1.7.4.1, the CQ is on 1.7.0.4, I'll just remove this assert.

[commit-bot: I haz the power, 2012-05-07 16:09:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10310034/8001

[commit-bot: I haz the power, 2012-05-07 16:17:23]

Change committed as 135651